* [PATCH] iio: twl4030-madc: Pass the IRQF_ONESHOT flag
@ 2015-05-24 20:39 Fabio Estevam
2015-06-07 16:28 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2015-05-24 20:39 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/iio/adc/twl4030-madc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
index 94c5f05..4caecbe 100644
--- a/drivers/iio/adc/twl4030-madc.c
+++ b/drivers/iio/adc/twl4030-madc.c
@@ -835,7 +835,8 @@ static int twl4030_madc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
twl4030_madc_threaded_irq_handler,
- IRQF_TRIGGER_RISING, "twl4030_madc", madc);
+ IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ "twl4030_madc", madc);
if (ret) {
dev_err(&pdev->dev, "could not request irq\n");
goto err_i2c;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: twl4030-madc: Pass the IRQF_ONESHOT flag
2015-05-24 20:39 [PATCH] iio: twl4030-madc: Pass the IRQF_ONESHOT flag Fabio Estevam
@ 2015-06-07 16:28 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-06-07 16:28 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-iio, Fabio Estevam
On 24/05/15 21:39, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
> threaded IRQs without a primary handler need to be requested with
> IRQF_ONESHOT, otherwise the request will fail.
>
> So pass the IRQF_ONESHOT flag in this case.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/misc/irqf_oneshot.cocci.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
> ---
> drivers/iio/adc/twl4030-madc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
> index 94c5f05..4caecbe 100644
> --- a/drivers/iio/adc/twl4030-madc.c
> +++ b/drivers/iio/adc/twl4030-madc.c
> @@ -835,7 +835,8 @@ static int twl4030_madc_probe(struct platform_device *pdev)
> irq = platform_get_irq(pdev, 0);
> ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> twl4030_madc_threaded_irq_handler,
> - IRQF_TRIGGER_RISING, "twl4030_madc", madc);
> + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> + "twl4030_madc", madc);
> if (ret) {
> dev_err(&pdev->dev, "could not request irq\n");
> goto err_i2c;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-07 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-24 20:39 [PATCH] iio: twl4030-madc: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-06-07 16:28 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).