From: Jonathan Cameron <jic23@kernel.org>
To: Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Cc: Naidu Tellapati <naidu.tellapati@imgtec.com>,
James Hartley <james.hartley@imgtec.com>,
phani.movva@imgtec.com
Subject: Re: [PATCH 5/5] iio: adc: cc10001: Power-up the ADC at probe time when used remotely
Date: Sun, 14 Jun 2015 12:22:04 +0100 [thread overview]
Message-ID: <557D63DC.4000005@kernel.org> (raw)
In-Reply-To: <55747588.9000707@kernel.org>
On 07/06/15 17:47, Jonathan Cameron wrote:
> On 26/05/15 14:27, Ezequiel Garcia wrote:
>>
>>
>> On 05/08/2015 10:41 AM, Jonathan Cameron wrote:
>>> On 07/05/15 17:24, Ezequiel Garcia wrote:
>>>> From: Naidu Tellapati <naidu.tellapati@imgtec.com>
>>>>
>>>> The ADC is typically shared with remote CPUs not running Linux.
>>>> However, there is only one register to power-up/power-down. Remote CPUs
>>>> aren't able to power-up the ADC, and rely in Linux doing it instead.
>>>>
>>>> This commit uses the adc-reserved-channels devicetree property to
>>>> distinguish shared usage. In this case, the ADC is powered up at
>>>> probe time.
>>>>
>>>> If the ADC is used only by the CPU running Linux, power-up/down
>>>> at runtime, only when neeeded.
>>>>
>>>> Signed-off-by: Naidu Tellapati <naidu.tellapati@imgtec.com>
>>>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
>>> Seems sensible to me, but as you observe it's not a fix as such, so
>>> will hold this until the other patches have propagated through to
>>> the togreg tree.
>>>
>>> Feel free to remind me if I seem to have forgotten!
>>>
>>
>> Ping.
> They haven't made it to the togreg tree yet! Will pick up when I next
> go through a pull request...
Now they are there. Applied to the togreg branch of iio.git.
Timing was rather against us this time, so this won't hit until the next
merge cycle now.
Sorry about that, been a busy few months!
Jonathan
prev parent reply other threads:[~2015-06-14 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 21:24 [PATCH 5/5] iio: adc: cc10001: Power-up the ADC at probe time when used remotely Ezequiel Garcia
2015-05-08 13:41 ` Jonathan Cameron
2015-05-26 13:27 ` Ezequiel Garcia
2015-06-07 16:47 ` Jonathan Cameron
2015-06-14 11:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557D63DC.4000005@kernel.org \
--to=jic23@kernel.org \
--cc=ezequiel.garcia@imgtec.com \
--cc=james.hartley@imgtec.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=naidu.tellapati@imgtec.com \
--cc=phani.movva@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).