Re: [PATCH v2 1/2] iio: accel: STK8BA50: suspend sensor on init errors

[Jonathan Cameron <jic23@kernel.org>]

On 19/06/15 15:56, Tiberiu Breana wrote:
> Put chip in 'suspend' mode in case something goes wrong
> during probe.
> 
> Signed-off-by: Tiberiu Breana <tiberiu.a.breana@intel.com>
Applied to the togreg branch of iio.git - initially pushed
out as testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> no changes since v1
> ---
>  drivers/iio/accel/stk8ba50.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c
> index 92229bd..9836880 100644
> --- a/drivers/iio/accel/stk8ba50.c
> +++ b/drivers/iio/accel/stk8ba50.c
> @@ -265,7 +265,7 @@ static int stk8ba50_probe(struct i2c_client *client,
>  			STK8BA50_REG_SWRST, STK8BA50_RESET_CMD);
>  	if (ret < 0) {
>  		dev_err(&client->dev, "failed to reset sensor\n");
> -		return ret;
> +		goto err_power_off;
>  	}
>  
>  	/* The default range is +/-2g */
> @@ -277,10 +277,14 @@ static int stk8ba50_probe(struct i2c_client *client,
>  	ret = iio_device_register(indio_dev);
>  	if (ret < 0) {
>  		dev_err(&client->dev, "device_register failed\n");
> -		stk8ba50_set_power(data, STK8BA50_MODE_SUSPEND);
> +		goto err_power_off;
>  	}
>  
>  	return ret;
> +
> +err_power_off:
> +	stk8ba50_set_power(data, STK8BA50_MODE_SUSPEND);
> +	return ret;
>  }
>  
>  static int stk8ba50_remove(struct i2c_client *client)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in