From: Jonathan Cameron <jic23@kernel.org>
To: Octavian Purdila <octavian.purdila@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Laurentiu Palcu <laurentiu.palcu@intel.com>
Subject: Re: [PATCH 1/3] iio:accel:bmc150-accel: fix counting direction
Date: Sun, 21 Jun 2015 14:43:14 +0100 [thread overview]
Message-ID: <5586BF72.4050601@kernel.org> (raw)
In-Reply-To: <CAE1zot+y7izi2vJDg7q+VT+GMPdbNymuUmsAOQP0MBVAmzNETw@mail.gmail.com>
On 16/06/15 11:31, Octavian Purdila wrote:
> On Tue, Jun 16, 2015 at 12:48 AM, Hartmut Knaack <knaack.h@gmx.de> wrote:
>>
>> In bmc150_accel_unregister_triggers() triggers should be unregistered in
>> reverse order of registration. Trigger registration starts with number 0,
>> counting up. In consequence, trigger number needs to be count down here.
>>
>> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
>
> Reviewed-by: Octavian Purdila <octavian.purdila@intel.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
>
>
>> ---
>> drivers/iio/accel/bmc150-accel.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
>> index 4e70f51..cc5a357 100644
>> --- a/drivers/iio/accel/bmc150-accel.c
>> +++ b/drivers/iio/accel/bmc150-accel.c
>> @@ -1464,7 +1464,7 @@ static void bmc150_accel_unregister_triggers(struct bmc150_accel_data *data,
>> {
>> int i;
>>
>> - for (i = from; i >= 0; i++) {
>> + for (i = from; i >= 0; i--) {
>> if (data->triggers[i].indio_trig) {
>> iio_trigger_unregister(data->triggers[i].indio_trig);
>> data->triggers[i].indio_trig = NULL;
>> --
>> 2.3.6
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
next prev parent reply other threads:[~2015-06-21 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 21:48 [PATCH 0/3] bmc150-accel fixes and cleanup Hartmut Knaack
2015-06-15 21:48 ` [PATCH 1/3] iio:accel:bmc150-accel: fix counting direction Hartmut Knaack
2015-06-16 10:31 ` Octavian Purdila
2015-06-21 13:43 ` Jonathan Cameron [this message]
2015-06-15 21:48 ` [PATCH 2/3] iio:accel:bmc150-accel: make use of mask definition Hartmut Knaack
2015-06-16 10:34 ` Octavian Purdila
2015-06-21 13:45 ` Jonathan Cameron
2015-06-15 21:48 ` [PATCH 3/3] iio:accel:bmc150-accel: code style cleanup Hartmut Knaack
2015-06-16 10:33 ` Octavian Purdila
2015-06-21 13:46 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5586BF72.4050601@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=laurentiu.palcu@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox