From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5587C6AB.8070903@metafoo.de> Date: Mon, 22 Jun 2015 10:26:19 +0200 From: Lars-Peter Clausen MIME-Version: 1.0 To: Daniel Baluta , Jonathan Cameron CC: Cristina Opriceana , Peter Meerwald , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List , "octavian.purdila@intel.com" Subject: Re: [PATCH] iio: Fix parameters in iio_triggered_buffer_setup References: <20150611120635.GA15709@Inspiron> <557D5562.8020209@kernel.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed List-ID: On 06/21/2015 03:57 PM, Daniel Baluta wrote: > On Sun, Jun 14, 2015 at 1:20 PM, Jonathan Cameron wrote: >> On 11/06/15 13:06, Cristina Opriceana wrote: >>> This patch renames the top half handler and the bottom half handler >>> of iio_triggered_buffer_setup() in accordance with their usage. >>> The names of the parameters were swapped, thus creating confusion. >>> >>> Signed-off-by: Cristina Opriceana >> Good point. This is definitely misleading. I wonder if the _th naming >> is a good idea anymore though given that the bottom half (in the traditional >> sense) is now a thread based call and hence the th might be confusing? >> Perhaps the h and thread naming used in the pollfunc code would be clearer? >> > > Sounds like a good idea. Cristina can prepare a patch for this. > >> Lars, this bit was yours originally. Any thoughts? Jonathan, that's your naming convention I merely added the wrapper function. I'm OK with changing the naming.