From: Andreas Dannenberg <dannenberg@ti.com>
To: Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH v3 1/2] iio: light: add support for TI's opt3001 light sensor
Date: Wed, 8 Jul 2015 11:44:22 -0500 [thread overview]
Message-ID: <559D5366.8030003@ti.com> (raw)
In-Reply-To: <55993A4C.10105@kernel.org>
On 07/05/2015 09:08 AM, Jonathan Cameron wrote:
<snip>
> Looking pretty good to me, though I'd like to give Peter time to take
> another look and give his reviewed-by etc.
>
> One really minor suggestion from me...
> <snip>
>> +
>> +static int opt3001_probe(struct i2c_client *client,
>> + const struct i2c_device_id *id)
>> +{
>> + struct device *dev = &client->dev;
>> +
>> + struct iio_dev *iio;
>> + struct opt3001 *opt;
>> + int irq = client->irq;
>> + int ret = -ENOMEM;
>> +
>> + iio = devm_iio_device_alloc(dev, sizeof(*opt));
>> + if (!iio)
> return -ENOMEM; would be cleaner, then there is no need to initialize
> ret either.
Hi Jonathan,
thanks for looking at my code. While we are waiting for additional feedback would you
like me to go ahead and re-spin/re-test the patch with your latest suggestion?
Regards,
--
Andreas Dannenberg
Texas Instruments Inc.
next prev parent reply other threads:[~2015-07-08 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 22:27 [PATCH v3 0/2] iio: light: add support for TI's opt3001 light sensor Andreas Dannenberg
2015-07-02 22:27 ` [PATCH v3 1/2] " Andreas Dannenberg
2015-07-05 14:08 ` Jonathan Cameron
2015-07-08 16:44 ` Andreas Dannenberg [this message]
2015-07-19 13:16 ` Jonathan Cameron
2015-07-02 22:27 ` [PATCH v3 2/2] iio: light: opt3001: Add device tree binding documentation Andreas Dannenberg
2015-07-05 14:09 ` Jonathan Cameron
2015-07-19 13:17 ` Jonathan Cameron
2015-07-20 18:22 ` Andreas Dannenberg
2015-07-23 20:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559D5366.8030003@ti.com \
--to=dannenberg@ti.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).