From: Jonathan Cameron <jic23@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Marek Vasut" <marex@denx.de>,
"Kristina Martšenko" <kristina.martsenko@gmail.com>,
"Fabio Estevam" <fabio.estevam@freescale.com>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/6] iio: mxs-lradc: clarify supported devices
Date: Sun, 19 Jul 2015 10:32:25 +0100 [thread overview]
Message-ID: <55AB6EA9.7020909@kernel.org> (raw)
In-Reply-To: <1437222646-8742-2-git-send-email-stefan.wahren@i2se.com>
On 18/07/15 13:30, Stefan Wahren wrote:
> At the beginning the driver supported only i.MX28 SoC, but now the
> whole MXS platform. So remove any confusing comments which apply
> only to i.MX28.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied to the togreg branch of iio.git. Initially pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> .../bindings/staging/iio/adc/mxs-lradc.txt | 2 +-
> drivers/staging/iio/adc/mxs-lradc.c | 18 +++++++++---------
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt b/Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
> index 3075377..555fb11 100644
> --- a/Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
> +++ b/Documentation/devicetree/bindings/staging/iio/adc/mxs-lradc.txt
> @@ -1,4 +1,4 @@
> -* Freescale i.MX28 LRADC device driver
> +* Freescale MXS LRADC device driver
>
> Required properties:
> - compatible: Should be "fsl,imx23-lradc" for i.MX23 SoC and "fsl,imx28-lradc"
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index d7c5223..1ccb367 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -1,5 +1,5 @@
> /*
> - * Freescale i.MX28 LRADC driver
> + * Freescale MXS LRADC driver
> *
> * Copyright (c) 2012 DENX Software Engineering, GmbH.
> * Marek Vasut <marex@denx.de>
> @@ -1392,7 +1392,7 @@ static const struct iio_chan_spec mxs_lradc_chan_spec[] = {
> MXS_ADC_CHAN(4, IIO_VOLTAGE),
> MXS_ADC_CHAN(5, IIO_VOLTAGE),
> MXS_ADC_CHAN(6, IIO_VOLTAGE),
> - MXS_ADC_CHAN(7, IIO_VOLTAGE), /* VBATT */
> + MXS_ADC_CHAN(7, IIO_VOLTAGE),
> /* Combined Temperature sensors */
> {
> .type = IIO_TEMP,
> @@ -1411,12 +1411,12 @@ static const struct iio_chan_spec mxs_lradc_chan_spec[] = {
> .scan_index = -1,
> .channel = 9,
> },
> - MXS_ADC_CHAN(10, IIO_VOLTAGE), /* VDDIO */
> - MXS_ADC_CHAN(11, IIO_VOLTAGE), /* VTH */
> - MXS_ADC_CHAN(12, IIO_VOLTAGE), /* VDDA */
> - MXS_ADC_CHAN(13, IIO_VOLTAGE), /* VDDD */
> - MXS_ADC_CHAN(14, IIO_VOLTAGE), /* VBG */
> - MXS_ADC_CHAN(15, IIO_VOLTAGE), /* VDD5V */
> + MXS_ADC_CHAN(10, IIO_VOLTAGE),
> + MXS_ADC_CHAN(11, IIO_VOLTAGE),
> + MXS_ADC_CHAN(12, IIO_VOLTAGE),
> + MXS_ADC_CHAN(13, IIO_VOLTAGE),
> + MXS_ADC_CHAN(14, IIO_VOLTAGE),
> + MXS_ADC_CHAN(15, IIO_VOLTAGE),
> };
>
> static int mxs_lradc_hw_init(struct mxs_lradc *lradc)
> @@ -1707,6 +1707,6 @@ static struct platform_driver mxs_lradc_driver = {
> module_platform_driver(mxs_lradc_driver);
>
> MODULE_AUTHOR("Marek Vasut <marex@denx.de>");
> -MODULE_DESCRIPTION("Freescale i.MX28 LRADC driver");
> +MODULE_DESCRIPTION("Freescale MXS LRADC driver");
> MODULE_LICENSE("GPL v2");
> MODULE_ALIAS("platform:" DRIVER_NAME);
>
next prev parent reply other threads:[~2015-07-19 9:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 12:30 [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names Stefan Wahren
2015-07-18 12:30 ` [PATCH 1/6] iio: mxs-lradc: clarify supported devices Stefan Wahren
2015-07-19 9:32 ` Jonathan Cameron [this message]
2015-07-18 12:30 ` [PATCH 2/6] iio: mxs-lradc: fix some spelling errors Stefan Wahren
2015-07-19 9:33 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 3/6] iio: mxs-lradc: add missing include Stefan Wahren
2015-07-19 9:34 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 4/6] iio: mxs-lradc: remove unnecessary header includes Stefan Wahren
2015-07-19 9:35 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 5/6] iio: mxs-lradc: reorder " Stefan Wahren
2015-07-18 15:37 ` Marek Vasut
2015-07-19 9:37 ` Jonathan Cameron
2015-07-18 12:30 ` [PATCH 6/6] iio: mxs-lradc: add datasheet name for every usable channel Stefan Wahren
2015-07-19 9:40 ` Jonathan Cameron
2015-07-18 15:38 ` [PATCH V2 0/6] iio: mxs-lradc: Clean up and add datasheet names Marek Vasut
2015-07-19 9:45 ` Jonathan Cameron
2015-07-19 20:33 ` Dan Carpenter
2015-07-19 20:49 ` Dan Carpenter
2015-07-19 21:44 ` Jonathan Cameron
2015-07-19 22:06 ` Marek Vasut
2015-07-20 7:00 ` Dan Carpenter
2015-07-20 8:16 ` Marek Vasut
2015-07-19 21:08 ` Jonathan Cameron
2015-07-19 22:11 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AB6EA9.7020909@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=kristina.martsenko@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=pmeerw@pmeerw.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).