From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:47387 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbbGSNdX (ORCPT ); Sun, 19 Jul 2015 09:33:23 -0400 Message-ID: <55ABA720.7070705@kernel.org> Date: Sun, 19 Jul 2015 14:33:20 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: Martin Kepplinger , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, mfuzzey@parkeon.com, roberta.dobrescu@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org CC: Martin Kepplinger , Christoph Muellner , stable@vger.kernel.org Subject: Re: [BUG] [PATCH] iio: mma8452: use iio event type IIO_EV_TYPE_MAG References: <1436118618-24819-1-git-send-email-martink@posteo.de> In-Reply-To: <1436118618-24819-1-git-send-email-martink@posteo.de> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 05/07/15 18:50, Martin Kepplinger wrote: > IIO_EV_TYPE_THRESH in rising direction describes an event where the > threshold is crossed in rising direction, positive or negative values > being possible. This is not the case here. > > Since the threshold is no signed value and only the magnitude is compared, > IIO_EV_TYPE_MAG is what describes the behaviour of these devices, see the > sysfs-bus-iio ABI Documentation. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner > Cc: stable@vger.kernel.org Applied to the fixes-togreg branch of iio.git. Thanks, Jonathan > --- > > if we can resolve this quickly, I know what to base my work on ;) > > thanks! > > > drivers/iio/accel/mma8452.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index e8e2077..13ea1ea 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -557,21 +557,21 @@ static void mma8452_transient_interrupt(struct iio_dev *indio_dev) > if (src & MMA8452_TRANSIENT_SRC_XTRANSE) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_X, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & MMA8452_TRANSIENT_SRC_YTRANSE) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Y, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & MMA8452_TRANSIENT_SRC_ZTRANSE) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Z, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > } > @@ -644,7 +644,7 @@ static int mma8452_reg_access_dbg(struct iio_dev *indio_dev, > > static const struct iio_event_spec mma8452_transient_event[] = { > { > - .type = IIO_EV_TYPE_THRESH, > + .type = IIO_EV_TYPE_MAG, > .dir = IIO_EV_DIR_RISING, > .mask_separate = BIT(IIO_EV_INFO_ENABLE), > .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | >