From: Jonathan Cameron <jic23@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Matt Ranostay <mranostay@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
marex@denx.de, Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH 0/2] iio: temperature: add mcp98xx driver support
Date: Sun, 19 Jul 2015 16:35:43 +0100 [thread overview]
Message-ID: <55ABC3CF.8050603@kernel.org> (raw)
In-Reply-To: <20150719152429.GA3729@roeck-us.net>
On 19/07/15 16:24, Guenter Roeck wrote:
> On Sun, Jul 19, 2015 at 10:24:53AM +0100, Jonathan Cameron wrote:
>> On 19/07/15 04:04, Matt Ranostay wrote:
>>> This changeset adds driver support for the Microchip mcp98xx series of
>>> temperature sensors.
>>>
>
> MCP98xx is pretty a pretty far reaching claim. This could also be MCP9804
> or MCP9843, which are JC42 compatible sensor chips and supported by the jc42
> driver. Does the new driver claim to support those as well ?
Indeed. Generic driver names are almost always a bad idea!
>
> Guenter
>
>>> This includes temperature reading, and rising/falling threshold events.
>> Why an IIO driver? These parts already look to be supported in hwmon by
>> the lm75 driver. We need a pretty strong reason to contemplate having
>> support in both subsystems...
>>>
>>> Matt Ranostay (2):
>>> iio: temperature: DT binding doc for mcp98xx
>>> iio: temperature: add support for mcp98xx sensors
>>>
>>> .../bindings/iio/temperature/mcp98xx.txt | 22 +
>>> drivers/iio/temperature/Kconfig | 10 +
>>> drivers/iio/temperature/Makefile | 1 +
>>> drivers/iio/temperature/mcp98xx.c | 588 +++++++++++++++++++++
>>> 4 files changed, 621 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/iio/temperature/mcp98xx.txt
>>> create mode 100644 drivers/iio/temperature/mcp98xx.c
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-07-19 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 3:04 [PATCH 0/2] iio: temperature: add mcp98xx driver support Matt Ranostay
2015-07-19 3:04 ` [PATCH 1/2] iio: temperature: DT binding doc for mcp98xx Matt Ranostay
2015-07-19 3:04 ` [PATCH 2/2] iio: temperature: add support for mcp98xx sensors Matt Ranostay
2015-07-19 9:24 ` [PATCH 0/2] iio: temperature: add mcp98xx driver support Jonathan Cameron
2015-07-19 15:24 ` Guenter Roeck
2015-07-19 15:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ABC3CF.8050603@kernel.org \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marex@denx.de \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).