From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, Joo Aun Saw <jasaw@dius.com.au>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] tools: iio: make scale and offset files optional
Date: Thu, 23 Jul 2015 20:46:46 +0100 [thread overview]
Message-ID: <55B144A6.8010309@kernel.org> (raw)
In-Reply-To: <55B1406B.70005@gmx.de>
On 23/07/15 20:28, Hartmut Knaack wrote:
> Joo Aun Saw schrieb am 23.07.2015 um 04:53:
>> From: Joo Aun Saw <jasaw@dius.com.au>
>>
>> Make scale and offset optional by adding -ENOENT check as not all
>> drivers implement them.
>>
>> Signed-off-by: Joo Aun Saw <jasaw@dius.com.au>
> Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Thanks. Applied to the togreg branch of iio.git - initially
pushed out as testing (in this case to be completely ignored
- I think - but there we are ;)
Jonathan
>> ---
>> tools/iio/iio_utils.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
>> index c3f9e37..1dcdf03 100644
>> --- a/tools/iio/iio_utils.c
>> +++ b/tools/iio/iio_utils.c
>> @@ -487,7 +487,7 @@ int build_channel_array(const char *device_dir,
>> device_dir,
>> current->name,
>> current->generic_name);
>> - if (ret < 0)
>> + if ((ret < 0) && (ret != -ENOENT))
>> goto error_cleanup_array;
>>
>> ret = iioutils_get_param_float(¤t->offset,
>> @@ -495,7 +495,7 @@ int build_channel_array(const char *device_dir,
>> device_dir,
>> current->name,
>> current->generic_name);
>> - if (ret < 0)
>> + if ((ret < 0) && (ret != -ENOENT))
>> goto error_cleanup_array;
>>
>> ret = iioutils_get_type(¤t->is_signed,
>>
>
prev parent reply other threads:[~2015-07-23 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 2:53 [PATCH] tools: iio: make scale and offset files optional Joo Aun Saw
2015-07-23 19:28 ` Hartmut Knaack
2015-07-23 19:46 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B144A6.8010309@kernel.org \
--to=jic23@kernel.org \
--cc=jasaw@dius.com.au \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).