* [PATCH] iio: declare struct to fix warning
@ 2015-07-30 9:18 Pengyu Ma
2015-07-30 9:26 ` Pengyu Ma
2015-08-02 9:47 ` Lars-Peter Clausen
0 siblings, 2 replies; 4+ messages in thread
From: Pengyu Ma @ 2015-07-30 9:18 UTC (permalink / raw)
To: jic23, linux-kernel, linux-iio, pengyu.ma
When compile iio related driver the following warning shown:
include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
int (*set_trigger_state)(struct iio_trigger *trig, bool state);
include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
struct iio_dev *indio_dev);
1st warning: 'struct iio_trigger' was used before declaration;
2nd warning: 'struct iio_dev' was used without including head file.
Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
---
include/linux/iio/trigger.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index 68f46cd..cbe4286 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -9,6 +9,7 @@
#include <linux/irq.h>
#include <linux/module.h>
#include <linux/atomic.h>
+#include <linux/iio/iio.h>
#ifndef _IIO_TRIGGER_H_
#define _IIO_TRIGGER_H_
@@ -18,6 +19,8 @@ struct iio_subirq {
bool enabled;
};
+struct iio_trigger; /* forward declaration */
+
/**
* struct iio_trigger_ops - operations structure for an iio_trigger.
* @owner: used to monitor usage count of the trigger.
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: declare struct to fix warning
2015-07-30 9:18 [PATCH] iio: declare struct to fix warning Pengyu Ma
@ 2015-07-30 9:26 ` Pengyu Ma
2015-08-02 9:47 ` Lars-Peter Clausen
1 sibling, 0 replies; 4+ messages in thread
From: Pengyu Ma @ 2015-07-30 9:26 UTC (permalink / raw)
To: jic23, linux-kernel, linux-iio
Since my email doesn't subscribe lkml, I will send again with my gmail
Pengyu
On 07/30/2015 05:18 PM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
> int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
> struct iio_dev *indio_dev);
>
> 1st warning: 'struct iio_trigger' was used before declaration;
> 2nd warning: 'struct iio_dev' was used without including head file.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
> include/linux/iio/trigger.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 68f46cd..cbe4286 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -9,6 +9,7 @@
> #include <linux/irq.h>
> #include <linux/module.h>
> #include <linux/atomic.h>
> +#include <linux/iio/iio.h>
>
> #ifndef _IIO_TRIGGER_H_
> #define _IIO_TRIGGER_H_
> @@ -18,6 +19,8 @@ struct iio_subirq {
> bool enabled;
> };
>
> +struct iio_trigger; /* forward declaration */
> +
> /**
> * struct iio_trigger_ops - operations structure for an iio_trigger.
> * @owner: used to monitor usage count of the trigger.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: declare struct to fix warning
2015-07-30 9:18 [PATCH] iio: declare struct to fix warning Pengyu Ma
2015-07-30 9:26 ` Pengyu Ma
@ 2015-08-02 9:47 ` Lars-Peter Clausen
1 sibling, 0 replies; 4+ messages in thread
From: Lars-Peter Clausen @ 2015-08-02 9:47 UTC (permalink / raw)
To: Pengyu Ma, jic23, linux-kernel, linux-iio
On 07/30/2015 11:18 AM, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
> int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
> struct iio_dev *indio_dev);
>
> 1st warning: 'struct iio_trigger' was used before declaration;
> 2nd warning: 'struct iio_dev' was used without including head file.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> ---
> include/linux/iio/trigger.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 68f46cd..cbe4286 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -9,6 +9,7 @@
> #include <linux/irq.h>
> #include <linux/module.h>
> #include <linux/atomic.h>
> +#include <linux/iio/iio.h>
>
Instead of including iio.h just add a forward declaration for struct
iio_dev. We dont need to dereference the struct so that will be fine.
> #ifndef _IIO_TRIGGER_H_
> #define _IIO_TRIGGER_H_
> @@ -18,6 +19,8 @@ struct iio_subirq {
> bool enabled;
> };
>
> +struct iio_trigger; /* forward declaration */
> +
> /**
> * struct iio_trigger_ops - operations structure for an iio_trigger.
> * @owner: used to monitor usage count of the trigger.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] iio: declare struct to fix warning
@ 2015-07-30 9:28 Aaron Ma
0 siblings, 0 replies; 4+ messages in thread
From: Aaron Ma @ 2015-07-30 9:28 UTC (permalink / raw)
To: jic23, linux-kernel, linux-iio, Aaron Ma
When compile iio related driver the following warning shown:
include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
int (*set_trigger_state)(struct iio_trigger *trig, bool state);
include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
struct iio_dev *indio_dev);
1st warning: 'struct iio_trigger' was used before declaration;
2nd warning: 'struct iio_dev' was used without including head file.
Signed-off-by: Pengyu Ma <mapengyu@gmail.com>
---
include/linux/iio/trigger.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index 68f46cd..cbe4286 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -9,6 +9,7 @@
#include <linux/irq.h>
#include <linux/module.h>
#include <linux/atomic.h>
+#include <linux/iio/iio.h>
#ifndef _IIO_TRIGGER_H_
#define _IIO_TRIGGER_H_
@@ -18,6 +19,8 @@ struct iio_subirq {
bool enabled;
};
+struct iio_trigger; /* forward declaration */
+
/**
* struct iio_trigger_ops - operations structure for an iio_trigger.
* @owner: used to monitor usage count of the trigger.
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-02 9:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-30 9:18 [PATCH] iio: declare struct to fix warning Pengyu Ma
2015-07-30 9:26 ` Pengyu Ma
2015-08-02 9:47 ` Lars-Peter Clausen
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 9:28 Aaron Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).