From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57966 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754336AbbHHL2N (ORCPT ); Sat, 8 Aug 2015 07:28:13 -0400 Subject: Re: [PATCH V3] iio: declare struct to fix warning To: Daniel Baluta , Pengyu Ma References: <1438676274-8978-1-git-send-email-pengyu.ma@windriver.com> Cc: Linux Kernel Mailing List , "linux-iio@vger.kernel.org" From: Jonathan Cameron Message-ID: <55C5E7CB.1010100@kernel.org> Date: Sat, 8 Aug 2015 12:28:11 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 04/08/15 09:30, Daniel Baluta wrote: > On Tue, Aug 4, 2015 at 11:17 AM, Pengyu Ma wrote: >> When compile iio related driver the following warning shown: >> >> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger' >> declared inside parameter list >> int (*set_trigger_state)(struct iio_trigger *trig, bool state); >> >> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev' >> declared inside parameter list >> struct iio_dev *indio_dev); >> >> 'struct iio_dev' and 'struct iio_trigger' was used before declaration, >> forward declaration for these structs to fix warning. >> >> Signed-off-by: Pengyu Ma > > Acked-by: Daniel Baluta No need send a v4 just to add the acked-by inline. I'm happy to do that as I apply. Thanks, Jonathan > >> --- >> include/linux/iio/trigger.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h >> index fa76c79..1c9e028 100644 >> --- a/include/linux/iio/trigger.h >> +++ b/include/linux/iio/trigger.h >> @@ -18,6 +18,9 @@ struct iio_subirq { >> bool enabled; >> }; >> >> +struct iio_dev; >> +struct iio_trigger; >> + >> /** >> * struct iio_trigger_ops - operations structure for an iio_trigger. >> * @owner: used to monitor usage count of the trigger. >> -- >> 2.4.3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >