From: Jonathan Cameron <jic23@kernel.org>
To: Pengyu Ma <pengyu.ma@windriver.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH V4] iio: declare struct to fix warning
Date: Sat, 8 Aug 2015 12:29:53 +0100 [thread overview]
Message-ID: <55C5E831.5030907@kernel.org> (raw)
In-Reply-To: <1438677139-9393-1-git-send-email-pengyu.ma@windriver.com>
On 04/08/15 09:32, Pengyu Ma wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
> int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
> struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
As we have had no reports of a case of this causing trouble for
a mainlined driver, and we are reasonably late in the current cycle,
I have applied this for the next merge windows (togreg branch) rather
than sending it the fast way as a fix.
Note togreg will be initially pushed out as testing to the let the
autobuilders play with it.
Thanks,
Jonathan
> ---
> include/linux/iio/trigger.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..1c9e028 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,9 @@ struct iio_subirq {
> bool enabled;
> };
>
> +struct iio_dev;
> +struct iio_trigger;
> +
> /**
> * struct iio_trigger_ops - operations structure for an iio_trigger.
> * @owner: used to monitor usage count of the trigger.
>
prev parent reply other threads:[~2015-08-08 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 8:32 [PATCH V4] iio: declare struct to fix warning Pengyu Ma
2015-08-08 11:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C5E831.5030907@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengyu.ma@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).