From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Antoine Tenart <antoine.tenart@free-electrons.com>
Subject: Re: [PATCH v2 8/8] iio:adc:berlin2-adc: coding style cleanup
Date: Wed, 12 Aug 2015 22:14:46 +0100 [thread overview]
Message-ID: <55CBB746.4070200@kernel.org> (raw)
In-Reply-To: <cd3906aa7d64636cef9fd2f4f39e8efac983205a.1438035998.git.knaack.h@gmx.de>
On 27/07/15 23:39, Hartmut Knaack wrote:
> Some adjustment of indentation to make checkpatch.pl happy in strict mode.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> Acked-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Applied.
Jonathan
> ---
> drivers/iio/adc/berlin2-adc.c | 64 +++++++++++++++++++++++--------------------
> 1 file changed, 35 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/iio/adc/berlin2-adc.c b/drivers/iio/adc/berlin2-adc.c
> index 13cfeb494e34..71c806ecc722 100644
> --- a/drivers/iio/adc/berlin2-adc.c
> +++ b/drivers/iio/adc/berlin2-adc.c
> @@ -78,13 +78,13 @@ struct berlin2_adc_priv {
> };
>
> #define BERLIN2_ADC_CHANNEL(n, t) \
> - { \
> - .channel = n, \
> - .datasheet_name = "channel"#n, \
> - .type = t, \
> - .indexed = 1, \
> - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
> - }
> + { \
> + .channel = n, \
> + .datasheet_name = "channel"#n, \
> + .type = t, \
> + .indexed = 1, \
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
> + }
>
> static const struct iio_chan_spec berlin2_adc_channels[] = {
> BERLIN2_ADC_CHANNEL(0, IIO_VOLTAGE), /* external input */
> @@ -117,16 +117,18 @@ static int berlin2_adc_read(struct iio_dev *indio_dev, int channel)
>
> /* Configure the ADC */
> regmap_update_bits(priv->regmap, BERLIN2_SM_CTRL,
> - BERLIN2_SM_CTRL_ADC_RESET | BERLIN2_SM_CTRL_ADC_SEL_MASK
> - | BERLIN2_SM_CTRL_ADC_START,
> - BERLIN2_SM_CTRL_ADC_SEL(channel) | BERLIN2_SM_CTRL_ADC_START);
> + BERLIN2_SM_CTRL_ADC_RESET |
> + BERLIN2_SM_CTRL_ADC_SEL_MASK |
> + BERLIN2_SM_CTRL_ADC_START,
> + BERLIN2_SM_CTRL_ADC_SEL(channel) |
> + BERLIN2_SM_CTRL_ADC_START);
>
> ret = wait_event_interruptible_timeout(priv->wq, priv->data_available,
> - msecs_to_jiffies(1000));
> + msecs_to_jiffies(1000));
>
> /* Disable the interrupts */
> regmap_update_bits(priv->regmap, BERLIN2_SM_ADC_STATUS,
> - BERLIN2_SM_ADC_STATUS_INT_EN(channel), 0);
> + BERLIN2_SM_ADC_STATUS_INT_EN(channel), 0);
>
> if (ret == 0)
> ret = -ETIMEDOUT;
> @@ -136,7 +138,7 @@ static int berlin2_adc_read(struct iio_dev *indio_dev, int channel)
> }
>
> regmap_update_bits(priv->regmap, BERLIN2_SM_CTRL,
> - BERLIN2_SM_CTRL_ADC_START, 0);
> + BERLIN2_SM_CTRL_ADC_START, 0);
>
> data = priv->data;
> priv->data_available = false;
> @@ -159,22 +161,25 @@ static int berlin2_adc_tsen_read(struct iio_dev *indio_dev)
>
> /* Configure the ADC */
> regmap_update_bits(priv->regmap, BERLIN2_SM_CTRL,
> - BERLIN2_SM_CTRL_TSEN_RESET | BERLIN2_SM_CTRL_ADC_ROTATE,
> - BERLIN2_SM_CTRL_ADC_ROTATE);
> + BERLIN2_SM_CTRL_TSEN_RESET |
> + BERLIN2_SM_CTRL_ADC_ROTATE,
> + BERLIN2_SM_CTRL_ADC_ROTATE);
>
> /* Configure the temperature sensor */
> regmap_update_bits(priv->regmap, BERLIN2_SM_TSEN_CTRL,
> - BERLIN2_SM_TSEN_CTRL_TRIM_MASK | BERLIN2_SM_TSEN_CTRL_SETTLING_MASK
> - | BERLIN2_SM_TSEN_CTRL_START,
> - BERLIN2_SM_TSEN_CTRL_TRIM(3) | BERLIN2_SM_TSEN_CTRL_SETTLING_12
> - | BERLIN2_SM_TSEN_CTRL_START);
> + BERLIN2_SM_TSEN_CTRL_TRIM_MASK |
> + BERLIN2_SM_TSEN_CTRL_SETTLING_MASK |
> + BERLIN2_SM_TSEN_CTRL_START,
> + BERLIN2_SM_TSEN_CTRL_TRIM(3) |
> + BERLIN2_SM_TSEN_CTRL_SETTLING_12 |
> + BERLIN2_SM_TSEN_CTRL_START);
>
> ret = wait_event_interruptible_timeout(priv->wq, priv->data_available,
> - msecs_to_jiffies(1000));
> + msecs_to_jiffies(1000));
>
> /* Disable interrupts */
> regmap_update_bits(priv->regmap, BERLIN2_SM_TSEN_STATUS,
> - BERLIN2_SM_TSEN_STATUS_INT_EN, 0);
> + BERLIN2_SM_TSEN_STATUS_INT_EN, 0);
>
> if (ret == 0)
> ret = -ETIMEDOUT;
> @@ -184,7 +189,7 @@ static int berlin2_adc_tsen_read(struct iio_dev *indio_dev)
> }
>
> regmap_update_bits(priv->regmap, BERLIN2_SM_TSEN_CTRL,
> - BERLIN2_SM_TSEN_CTRL_START, 0);
> + BERLIN2_SM_TSEN_CTRL_START, 0);
>
> data = priv->data;
> priv->data_available = false;
> @@ -195,8 +200,8 @@ static int berlin2_adc_tsen_read(struct iio_dev *indio_dev)
> }
>
> static int berlin2_adc_read_raw(struct iio_dev *indio_dev,
> - struct iio_chan_spec const *chan, int *val, int *val2,
> - long mask)
> + struct iio_chan_spec const *chan, int *val,
> + int *val2, long mask)
> {
> int temp;
>
> @@ -305,12 +310,12 @@ static int berlin2_adc_probe(struct platform_device *pdev)
> return tsen_irq;
>
> ret = devm_request_irq(&pdev->dev, irq, berlin2_adc_irq, 0,
> - pdev->dev.driver->name, indio_dev);
> + pdev->dev.driver->name, indio_dev);
> if (ret)
> return ret;
>
> ret = devm_request_irq(&pdev->dev, tsen_irq, berlin2_adc_tsen_irq,
> - 0, pdev->dev.driver->name, indio_dev);
> + 0, pdev->dev.driver->name, indio_dev);
> if (ret)
> return ret;
>
> @@ -327,13 +332,14 @@ static int berlin2_adc_probe(struct platform_device *pdev)
>
> /* Power up the ADC */
> regmap_update_bits(priv->regmap, BERLIN2_SM_CTRL,
> - BERLIN2_SM_CTRL_ADC_POWER, BERLIN2_SM_CTRL_ADC_POWER);
> + BERLIN2_SM_CTRL_ADC_POWER,
> + BERLIN2_SM_CTRL_ADC_POWER);
>
> ret = iio_device_register(indio_dev);
> if (ret) {
> /* Power down the ADC */
> regmap_update_bits(priv->regmap, BERLIN2_SM_CTRL,
> - BERLIN2_SM_CTRL_ADC_POWER, 0);
> + BERLIN2_SM_CTRL_ADC_POWER, 0);
> return ret;
> }
>
> @@ -349,7 +355,7 @@ static int berlin2_adc_remove(struct platform_device *pdev)
>
> /* Power down the ADC */
> regmap_update_bits(priv->regmap, BERLIN2_SM_CTRL,
> - BERLIN2_SM_CTRL_ADC_POWER, 0);
> + BERLIN2_SM_CTRL_ADC_POWER, 0);
>
> return 0;
> }
>
prev parent reply other threads:[~2015-08-12 21:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 22:38 [PATCH v2 0/8] berlin2-adc fixes and cleanup Hartmut Knaack
2015-07-27 22:38 ` [PATCH v2 1/8] iio:adc:berlin2-adc: Fix register definition Hartmut Knaack
2015-07-30 12:47 ` Antoine Tenart
2015-08-02 17:59 ` Jonathan Cameron
2015-07-27 22:38 ` [PATCH v2 2/8] iio:adc:berlin2-adc: pass up real error code Hartmut Knaack
2015-08-02 18:06 ` Jonathan Cameron
2015-07-27 22:38 ` [PATCH v2 3/8] iio:adc:berlin2-adc: use GENMASK and BIT for masks Hartmut Knaack
2015-07-30 12:47 ` Antoine Tenart
2015-08-02 18:07 ` Jonathan Cameron
2015-08-12 21:11 ` Jonathan Cameron
2015-07-27 22:39 ` [PATCH v2 4/8] iio:adc:berlin2-adc: constify iio_chan_spec Hartmut Knaack
2015-08-02 18:07 ` Jonathan Cameron
2015-07-27 22:39 ` [PATCH v2 5/8] iio:adc:berlin2-adc: use short operator format Hartmut Knaack
2015-08-02 18:08 ` Jonathan Cameron
2015-07-27 22:39 ` [PATCH v2 6/8] iio:adc:berlin2-adc: use channel-array size directly Hartmut Knaack
2015-08-02 18:09 ` Jonathan Cameron
2015-07-27 22:39 ` [PATCH v2 7/8] iio:adc:berlin2-adc: enable interrupts with mutex locked Hartmut Knaack
2015-07-31 23:54 ` Hartmut Knaack
2015-08-12 21:13 ` Jonathan Cameron
2015-08-17 12:57 ` Antoine Tenart
2015-07-27 22:39 ` [PATCH v2 8/8] iio:adc:berlin2-adc: coding style cleanup Hartmut Knaack
2015-08-12 21:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CBB746.4070200@kernel.org \
--to=jic23@kernel.org \
--cc=antoine.tenart@free-electrons.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).