From: Lars-Peter Clausen <lars@metafoo.de>
To: Crt Mori <cmo@melexis.com>, Peter Meerwald <pmeerw@pmeerw.net>
Cc: Vianney le Clement de Saint-Marcq
<vianney.leclement@essensium.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: mlx90614: Implement filter configuration
Date: Thu, 13 Aug 2015 11:17:37 +0200 [thread overview]
Message-ID: <55CC60B1.6060706@metafoo.de> (raw)
In-Reply-To: <CAKv63us8NL7FiBOteGTdGBXG5Lxo3Lw8rSzv=aix-snDsrqpNQ@mail.gmail.com>
On 08/13/2015 11:12 AM, Crt Mori wrote:
> On 13 August 2015 at 10:58, Peter Meerwald <pmeerw@pmeerw.net> wrote:
>> On Thu, 13 Aug 2015, Crt Mori wrote:
>>
>>> Implemented Low pass 3db frequency filter which configures
>>> FIR and IIR values within the configuration register of EEPROM.
>>> For more standardized interface we have fixed the FIR value
>>> to 1024, while changes in IIR value are directly connected to
>>> filter responses. The new datasheet version will provide a
>>> simplified table (also in reStructured text format below) with
>>> this change, to provide quick overview of possible settings.
>>
>> nitpicking below
>>
>> the patch add .owner = THIS_MODULE, which is unrelated to the rest of the
>> patch
>>
> Ty for noticing - it is already in there, dont know why diff marked it.
It was removed in upstream since it is not necessary.
prev parent reply other threads:[~2015-08-13 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 7:14 [PATCH] iio: mlx90614: Implement filter configuration Crt Mori
2015-08-13 8:58 ` Peter Meerwald
2015-08-13 9:12 ` Crt Mori
2015-08-13 9:17 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC60B1.6060706@metafoo.de \
--to=lars@metafoo.de \
--cc=cmo@melexis.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=vianney.leclement@essensium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).