From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:49067 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752659AbbHOT5Y (ORCPT ); Sat, 15 Aug 2015 15:57:24 -0400 Subject: Re: [PATCH 05/19] staging: iio: Remove unnecessary externs To: Lars-Peter Clausen , Joe Perches , devel@driverdev.osuosl.org, Michael Hennerich References: <55CA424F.1030704@metafoo.de> Cc: Hartmut Knaack , Peter Meerwald , Greg Kroah-Hartman , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <55CF99A1.1000701@kernel.org> Date: Sat, 15 Aug 2015 20:57:21 +0100 MIME-Version: 1.0 In-Reply-To: <55CA424F.1030704@metafoo.de> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 11/08/15 19:43, Lars-Peter Clausen wrote: > On 08/10/2015 11:51 PM, Joe Perches wrote: >> Using 'extern' is not necessary for function prototypes. >> >> Signed-off-by: Joe Perches > > Acked-by: Lars-Peter Clausen > Applied to the togreg branch of iio.git. 4.4 material now probably. Thanks, Jonathan > Thanks. > >> --- >> drivers/staging/iio/meter/ade7854.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/iio/meter/ade7854.h b/drivers/staging/iio/meter/ade7854.h >> index 52ca541..52f4195 100644 >> --- a/drivers/staging/iio/meter/ade7854.h >> +++ b/drivers/staging/iio/meter/ade7854.h >> @@ -168,7 +168,7 @@ struct ade7854_state { >> >> }; >> >> -extern int ade7854_probe(struct iio_dev *indio_dev, struct device *dev); >> -extern int ade7854_remove(struct iio_dev *indio_dev); >> +int ade7854_probe(struct iio_dev *indio_dev, struct device *dev); >> +int ade7854_remove(struct iio_dev *indio_dev); >> >> #endif >> >