From: Jonathan Cameron <jic23@kernel.org>
To: Cristina Opriceana <cristina.opriceana@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
daniel.baluta@intel.com
Subject: Re: [PATCH 1/2] Staging: iio: trigger: Alignment should match open parenthesis
Date: Sat, 15 Aug 2015 20:59:06 +0100 [thread overview]
Message-ID: <55CF9A0A.5020907@kernel.org> (raw)
In-Reply-To: <0146dc807925c66b3098993e4cc2f3a0a0a4f746.1439286814.git.cristina.opriceana@gmail.com>
On 11/08/15 11:18, Cristina Opriceana wrote:
> Fix alignment for function parameters as suggested by checkpatch.pl.
>
> Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Whilst I find it a little hard to care about tidying up in these two drivers,
we haven't explicitly noted they are both on their way out in the medium
term and it does no harm.
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 7 ++++---
> drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> index 3c1c8c6..9fe48ef 100644
> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
> @@ -79,7 +79,8 @@ static int iio_bfin_tmr_set_state(struct iio_trigger *trig, bool state)
> }
>
> static ssize_t iio_bfin_tmr_frequency_store(struct device *dev,
> - struct device_attribute *attr, const char *buf, size_t count)
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> {
> struct iio_trigger *trig = to_iio_trigger(dev);
> struct bfin_tmr_state *st = iio_trigger_get_drvdata(trig);
> @@ -116,8 +117,8 @@ static ssize_t iio_bfin_tmr_frequency_store(struct device *dev,
> }
>
> static ssize_t iio_bfin_tmr_frequency_show(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> struct iio_trigger *trig = to_iio_trigger(dev);
> struct bfin_tmr_state *st = iio_trigger_get_drvdata(trig);
> diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> index 0c1976d..a2a42c2 100644
> --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> @@ -37,7 +37,7 @@ static int iio_trig_periodic_rtc_set_state(struct iio_trigger *trig, bool state)
> if (trig_info->frequency == 0 && state)
> return -EINVAL;
> dev_dbg(&trig_info->rtc->dev, "trigger frequency is %u\n",
> - trig_info->frequency);
> + trig_info->frequency);
> ret = rtc_irq_set_state(trig_info->rtc, &trig_info->task, state);
> if (ret == 0)
> trig_info->state = state;
>
next prev parent reply other threads:[~2015-08-15 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 10:15 [PATCH 0/2] Staging: iio: trigger: Fix style issues Cristina Opriceana
2015-08-11 10:18 ` [PATCH 1/2] Staging: iio: trigger: Alignment should match open parenthesis Cristina Opriceana
2015-08-15 19:59 ` Jonathan Cameron [this message]
2015-08-11 10:20 ` [PATCH 2/2] Staging: iio: trigger: Use braces on both branches of if statement Cristina Opriceana
2015-08-15 20:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CF9A0A.5020907@kernel.org \
--to=jic23@kernel.org \
--cc=cristina.opriceana@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).