From: Jonathan Cameron <jic23@kernel.org>
To: Cristina Opriceana <cristina.opriceana@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
daniel.baluta@intel.com
Subject: Re: [PATCH 2/2] Staging: iio: trigger: Use braces on both branches of if statement
Date: Sat, 15 Aug 2015 21:02:00 +0100 [thread overview]
Message-ID: <55CF9AB8.1030503@kernel.org> (raw)
In-Reply-To: <d9079236646cd08ab1f55a71ec67830dd8813e72.1439286814.git.cristina.opriceana@gmail.com>
On 11/08/15 11:20, Cristina Opriceana wrote:
> Fix style issue related to missing braces, detected by checkpatch.pl.
>
> Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Applied to the togreg branch of iio.git.
This one used to be left as optional, so there are a lot of these in older
code (and in IIO you don't get much older than this!)
For reference, it is going away the moment the high resolution timer
trigger is in as this support is emulated in all modern rtc drivers
anyway (was using actual hardware in the rtc when this driver was written).
Anyhow, even code with a short likely time to live can be well formatted!
Applied.
Jonathan
> ---
> drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> index a2a42c2..2db8857 100644
> --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> @@ -74,8 +74,9 @@ static ssize_t iio_trig_periodic_write_freq(struct device *dev,
> if (ret == 0 && trig_info->state && trig_info->frequency == 0)
> ret = rtc_irq_set_state(trig_info->rtc,
> &trig_info->task, 1);
> - } else
> + } else {
> ret = rtc_irq_set_state(trig_info->rtc, &trig_info->task, 0);
> + }
> if (ret)
> goto error_ret;
>
>
prev parent reply other threads:[~2015-08-15 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 10:15 [PATCH 0/2] Staging: iio: trigger: Fix style issues Cristina Opriceana
2015-08-11 10:18 ` [PATCH 1/2] Staging: iio: trigger: Alignment should match open parenthesis Cristina Opriceana
2015-08-15 19:59 ` Jonathan Cameron
2015-08-11 10:20 ` [PATCH 2/2] Staging: iio: trigger: Use braces on both branches of if statement Cristina Opriceana
2015-08-15 20:02 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CF9AB8.1030503@kernel.org \
--to=jic23@kernel.org \
--cc=cristina.opriceana@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).