From: Jonathan Cameron <jic23@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-iio@vger.kernel.org,
Peter Meerwald <pmeerw@pmeerw.net>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>
Subject: Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information
Date: Sat, 22 Aug 2015 18:59:17 +0100 [thread overview]
Message-ID: <55D8B875.3060200@kernel.org> (raw)
In-Reply-To: <1440054451-1223-3-git-send-email-javier@osg.samsung.com>
On 20/08/15 08:07, Javier Martinez Canillas wrote:
> The SPI core always reports the MODALIAS uevent as "spi:<modalias>"
> regardless of the mechanism that was used to register the device
> (i.e: OF or board code) and the table that is used later to match
> the driver with the device (i.e: SPI id table or OF match table).
>
> So drivers needs to export the SPI id table and this be built into
> the module or udev won't have the necessary information to autoload
> the needed driver module when the device is added.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to the togreg branch of iio.git.
This is too late for the upcoming merge window so it will be queued up for
the next one.
Thanks,
Jonathan
> ---
>
> drivers/staging/iio/magnetometer/hmc5843_spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843_spi.c b/drivers/staging/iio/magnetometer/hmc5843_spi.c
> index 8e658f736e1f..4dfb372d2fec 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843_spi.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843_spi.c
> @@ -81,6 +81,7 @@ static const struct spi_device_id hmc5843_id[] = {
> { "hmc5983", HMC5983_ID },
> { }
> };
> +MODULE_DEVICE_TABLE(spi, hmc5843_id);
>
> static struct spi_driver hmc5843_driver = {
> .driver = {
>
next prev parent reply other threads:[~2015-08-22 17:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 7:07 [PATCH 00/18] Export SPI and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 01/18] iio: Export SPI module alias information " Javier Martinez Canillas
2015-08-20 15:49 ` Lars-Peter Clausen
2015-08-22 18:08 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information Javier Martinez Canillas
2015-08-22 17:59 ` Jonathan Cameron [this message]
2015-08-31 23:09 ` Javier Martinez Canillas
2015-09-05 16:31 ` Jonathan Cameron
2015-09-05 23:34 ` Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 10/18] iio: dac: ad7303: Add OF match table Javier Martinez Canillas
2015-08-20 15:49 ` Lars-Peter Clausen
2015-08-22 18:06 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 11/18] iio: adc: max1027: Set struct spi_driver .of_match_table Javier Martinez Canillas
2015-08-22 18:00 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 13/18] iio: adc: mcp320x: " Javier Martinez Canillas
2015-08-20 20:09 ` Michael Welling
2015-08-20 22:02 ` Javier Martinez Canillas
2015-08-20 22:29 ` Michael Welling
2015-08-20 22:48 ` Javier Martinez Canillas
2015-08-20 23:53 ` Michael Welling
2015-08-22 18:09 ` Jonathan Cameron
2015-08-22 17:48 ` Jonathan Cameron
2015-08-23 22:10 ` Rob Herring
2015-08-24 7:19 ` Javier Martinez Canillas
2015-08-20 7:07 ` [PATCH 14/18] iio: as3935: Add OF match table Javier Martinez Canillas
2015-08-22 18:02 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 15/18] iio: adc128s052: " Javier Martinez Canillas
2015-08-22 18:03 ` Jonathan Cameron
2015-08-20 7:07 ` [PATCH 16/18] iio: frequency: adf4350: " Javier Martinez Canillas
2015-08-20 15:49 ` Lars-Peter Clausen
2015-08-22 18:04 ` Jonathan Cameron
2015-08-20 21:11 ` [PATCH 00/18] Export SPI and OF module aliases in missing drivers Brian Norris
2015-08-20 21:50 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D8B875.3060200@kernel.org \
--to=jic23@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).