From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:38183 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753231AbbHVSCc (ORCPT ); Sat, 22 Aug 2015 14:02:32 -0400 Subject: Re: [PATCH 14/18] iio: as3935: Add OF match table To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-15-git-send-email-javier@osg.samsung.com> Cc: linux-iio@vger.kernel.org, Peter Meerwald , George McCollister , Lars-Peter Clausen , Hartmut Knaack From: Jonathan Cameron Message-ID: <55D8B936.1030501@kernel.org> Date: Sat, 22 Aug 2015 19:02:30 +0100 MIME-Version: 1.0 In-Reply-To: <1440054451-1223-15-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 20/08/15 08:07, Javier Martinez Canillas wrote: > The Documentation/devicetree/bindings/iio/proximity/as3935.txt DT binding > doc lists "ams,as3935" as a compatible string but the corresponding driver > does not have an OF match table. Add the table to the driver so the SPI > core can do an OF style match. > > Signed-off-by: Javier Martinez Canillas Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. > --- > > drivers/iio/proximity/as3935.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c > index bc0d68efd455..e95035136889 100644 > --- a/drivers/iio/proximity/as3935.c > +++ b/drivers/iio/proximity/as3935.c > @@ -434,6 +434,12 @@ static int as3935_remove(struct spi_device *spi) > return 0; > } > > +static const struct of_device_id as3935_of_match[] = { > + { .compatible = "ams,as3935", }, > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, as3935_of_match); > + > static const struct spi_device_id as3935_id[] = { > {"as3935", 0}, > {}, > @@ -443,6 +449,7 @@ MODULE_DEVICE_TABLE(spi, as3935_id); > static struct spi_driver as3935_driver = { > .driver = { > .name = "as3935", > + .of_match_table = of_match_ptr(as3935_of_match), > .owner = THIS_MODULE, > .pm = AS3935_PM_OPS, > }, >