From: Jonathan Cameron <jic23@kernel.org>
To: Axel Lin <axel.lin@ingics.com>, linux-iio@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Laxman Dewangan <ldewangan@nvidia.com>,
Olof Johansson <olof@lixom.net>
Subject: Re: IIO: ak8975: Why adding OF compatible string without vendor prefix?
Date: Mon, 31 Aug 2015 16:05:17 +0100 [thread overview]
Message-ID: <55E46D2D.1030303@kernel.org> (raw)
In-Reply-To: <1440996094.1500.1.camel@ingics.com>
On 31/08/15 05:41, Axel Lin wrote:
> Hi,
> I just found the ak8975_of_match table has compatible string without vendor
> prefix.
>
> static const struct of_device_id ak8975_of_match[] = {
> { .compatible = "asahi-kasei,ak8975", },
> { .compatible = "ak8975", },
> { .compatible = "asahi-kasei,ak8963", },
> { .compatible = "ak8963", },
> { .compatible = "asahi-kasei,ak09911", },
> { .compatible = "ak09911", },
> { .compatible = "asahi-kasei,ak09912", },
> { .compatible = "ak09912", },
> {}
> };
>
> This seems unusual, just curious why below compatible strings are required?
> { .compatible = "ak8975", },
> { .compatible = "ak8963", },
> { .compatible = "ak09911", },
> { .compatible = "ak09912", },
>
> Regards,
> Axel
>
This is an historical artefact. I2C (and for that matter SPI)
subsystems handled device tree registration in their cores.
Unfortunately they did it by matching against the registered
driver names and those don't include vendors.
This is still being unwound, but the upshot is that we have
boards with device trees out in the wild using the version without
a vendor string. Hence for backwards compatibility, both need
to be in the table.
Jonathan
prev parent reply other threads:[~2015-08-31 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 4:41 IIO: ak8975: Why adding OF compatible string without vendor prefix? Axel Lin
2015-08-31 15:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E46D2D.1030303@kernel.org \
--to=jic23@kernel.org \
--cc=axel.lin@ingics.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).