Re: [PATCH 02/18] staging: iio: hmc5843: Export missing SPI module alias information

[Jonathan Cameron <jic23@kernel.org>]

On 01/09/15 00:09, Javier Martinez Canillas wrote:
> Hello Jonathan,
> 
> On 08/22/2015 07:59 PM, Jonathan Cameron wrote:
>> On 20/08/15 08:07, Javier Martinez Canillas wrote:
>>> The SPI core always reports the MODALIAS uevent as "spi:<modalias>"
>>> regardless of the mechanism that was used to register the device
>>> (i.e: OF or board code) and the table that is used later to match
>>> the driver with the device (i.e: SPI id table or OF match table).
>>>
>>> So drivers needs to export the SPI id table and this be built into
>>> the module or udev won't have the necessary information to autoload
>>> the needed driver module when the device is added.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>> Applied to the togreg branch of iio.git.
>>
>> This is too late for the upcoming merge window so it will be queued up for
>> the next one.
>>
> 
> IMHO this patch and "[PATCH 01/18] iio: Export SPI module alias
> information in missing drivers" [0] are fixing broken module
> autoloading which are bugs so are material for the 4.3 -rc cycle.

It's a corner case.  Could also be argued that this isn't
a bug but rather a case of a feature (autoprobing) being added
that wasn't supported before.  It's not obligatory to support
autoloading (even if we would normally aim to do so).

I'm happy enough for a request to apply these to stable occurs
after they hit Linus' tree (as a trivial backport) but I don't
think they really deserve being sent on as fixes.

Of course, I might be missing something that means something is
actually broken, as opposed to not present.

Jonathan

>  
>> Thanks,
>>
>> Jonathan
> 
> [0]: https://lkml.org/lkml/2015/8/20/111
> 
> Best regards,
>