From: Jonathan Cameron <jic23@kernel.org>
To: Shraddha Barke <shraddha.6596@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Hartmut Knaack <knaack.h@gmx.de>,
Andreas Dilger <andreas.dilger@intel.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Staging: iio: addac: Prefer using the BIT macro
Date: Sat, 12 Sep 2015 10:57:27 +0100 [thread overview]
Message-ID: <55F3F707.6030908@kernel.org> (raw)
In-Reply-To: <1441902634-11129-1-git-send-email-shraddha.6596@gmail.com>
On 10/09/15 17:30, Shraddha Barke wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro.
>
> This was done with coccinelle:
>
> @@ int g; @@
>
> -(1 << g)
> +BIT(g)
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
A small process related point. These are reworked versions of your
earlier series. Please make that obvious with a V2 in the patch name.
A cover letter explaining what the changes were is also a useful addition.
I suspect a lot of reviewers do what I do and work backwards through their
email and hence need the indication that there is an earlier thread they
should be cross referring to.
Thanks,
Jonathan
> ---
> drivers/staging/iio/addac/adt7316.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 5b11b42..a1dd745 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -1756,43 +1756,43 @@ static irqreturn_t adt7316_event_handler(int irq, void *private)
> stat1 &= 0x1F;
>
> time = iio_get_time_ns();
> - if (stat1 & (1 << 0))
> + if (stat1 & BIT(0))
> iio_push_event(indio_dev,
> IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
> IIO_EV_TYPE_THRESH,
> IIO_EV_DIR_RISING),
> time);
> - if (stat1 & (1 << 1))
> + if (stat1 & BIT(1))
> iio_push_event(indio_dev,
> IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0,
> IIO_EV_TYPE_THRESH,
> IIO_EV_DIR_FALLING),
> time);
> - if (stat1 & (1 << 2))
> + if (stat1 & BIT(2))
> iio_push_event(indio_dev,
> IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1,
> IIO_EV_TYPE_THRESH,
> IIO_EV_DIR_RISING),
> time);
> - if (stat1 & (1 << 3))
> + if (stat1 & BIT(3))
> iio_push_event(indio_dev,
> IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1,
> IIO_EV_TYPE_THRESH,
> IIO_EV_DIR_FALLING),
> time);
> - if (stat1 & (1 << 5))
> + if (stat1 & BIT(5))
> iio_push_event(indio_dev,
> IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 1,
> IIO_EV_TYPE_THRESH,
> IIO_EV_DIR_EITHER),
> time);
> - if (stat1 & (1 << 6))
> + if (stat1 & BIT(6))
> iio_push_event(indio_dev,
> IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 2,
> IIO_EV_TYPE_THRESH,
> IIO_EV_DIR_EITHER),
> time);
> - if (stat1 & (1 << 7))
> + if (stat1 & BIT(7))
> iio_push_event(indio_dev,
> IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 3,
> IIO_EV_TYPE_THRESH,
>
prev parent reply other threads:[~2015-09-12 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 16:30 [PATCH 1/6] Staging: iio: addac: Prefer using the BIT macro Shraddha Barke
2015-09-10 16:30 ` [PATCH 2/6] Staging: iio: meter: " Shraddha Barke
2015-09-12 10:14 ` Jonathan Cameron
2015-09-10 16:30 ` [PATCH 3/6] Staging: lustre: libcfs: " Shraddha Barke
2015-09-12 9:53 ` [PATCH 1/6] Staging: iio: addac: " Jonathan Cameron
2015-09-12 9:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F3F707.6030908@kernel.org \
--to=jic23@kernel.org \
--cc=abbotti@mev.co.uk \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).