From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:55833 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754491AbbILJ53 (ORCPT ); Sat, 12 Sep 2015 05:57:29 -0400 Subject: Re: [PATCH 1/6] Staging: iio: addac: Prefer using the BIT macro To: Shraddha Barke , Greg Kroah-Hartman , Julia Lawall , Hartmut Knaack , Andreas Dilger References: <1441902634-11129-1-git-send-email-shraddha.6596@gmail.com> Cc: Ian Abbott , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <55F3F707.6030908@kernel.org> Date: Sat, 12 Sep 2015 10:57:27 +0100 MIME-Version: 1.0 In-Reply-To: <1441902634-11129-1-git-send-email-shraddha.6596@gmail.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/09/15 17:30, Shraddha Barke wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > > This was done with coccinelle: > > @@ int g; @@ > > -(1 << g) > +BIT(g) > > Signed-off-by: Shraddha Barke A small process related point. These are reworked versions of your earlier series. Please make that obvious with a V2 in the patch name. A cover letter explaining what the changes were is also a useful addition. I suspect a lot of reviewers do what I do and work backwards through their email and hence need the indication that there is an earlier thread they should be cross referring to. Thanks, Jonathan > --- > drivers/staging/iio/addac/adt7316.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c > index 5b11b42..a1dd745 100644 > --- a/drivers/staging/iio/addac/adt7316.c > +++ b/drivers/staging/iio/addac/adt7316.c > @@ -1756,43 +1756,43 @@ static irqreturn_t adt7316_event_handler(int irq, void *private) > stat1 &= 0x1F; > > time = iio_get_time_ns(); > - if (stat1 & (1 << 0)) > + if (stat1 & BIT(0)) > iio_push_event(indio_dev, > IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0, > IIO_EV_TYPE_THRESH, > IIO_EV_DIR_RISING), > time); > - if (stat1 & (1 << 1)) > + if (stat1 & BIT(1)) > iio_push_event(indio_dev, > IIO_UNMOD_EVENT_CODE(IIO_TEMP, 0, > IIO_EV_TYPE_THRESH, > IIO_EV_DIR_FALLING), > time); > - if (stat1 & (1 << 2)) > + if (stat1 & BIT(2)) > iio_push_event(indio_dev, > IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1, > IIO_EV_TYPE_THRESH, > IIO_EV_DIR_RISING), > time); > - if (stat1 & (1 << 3)) > + if (stat1 & BIT(3)) > iio_push_event(indio_dev, > IIO_UNMOD_EVENT_CODE(IIO_TEMP, 1, > IIO_EV_TYPE_THRESH, > IIO_EV_DIR_FALLING), > time); > - if (stat1 & (1 << 5)) > + if (stat1 & BIT(5)) > iio_push_event(indio_dev, > IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 1, > IIO_EV_TYPE_THRESH, > IIO_EV_DIR_EITHER), > time); > - if (stat1 & (1 << 6)) > + if (stat1 & BIT(6)) > iio_push_event(indio_dev, > IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 2, > IIO_EV_TYPE_THRESH, > IIO_EV_DIR_EITHER), > time); > - if (stat1 & (1 << 7)) > + if (stat1 & BIT(7)) > iio_push_event(indio_dev, > IIO_UNMOD_EVENT_CODE(IIO_VOLTAGE, 3, > IIO_EV_TYPE_THRESH, >