From: Rob Herring <robh@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jonathan Cameron <jic23@kernel.org>,
Peter Meerwald <pmeerw@pmeerw.net>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
plaes@plaes.org, linux-iio@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH] devicetree: bindings: Extend the bma180 bindings with bma250 info
Date: Thu, 17 Sep 2015 14:40:57 -0500 [thread overview]
Message-ID: <55FB1749.3050403@kernel.org> (raw)
In-Reply-To: <1442055169-16966-1-git-send-email-hdegoede@redhat.com>
On 09/12/2015 05:52 AM, Hans de Goede wrote:
> The bma180 / bma250 accelerometers share a driver (at least under Linux),
> so it makes sense to also have their bindings info in a single .txt.
>
> This commit extends the bma180 bindings with bma250 bindings, specifically
> it specifies how the 2 seperate interrupts the bma250 has must be listed
> in devicetree. The existing bma180 driver is already fully compatible
> with the specified bindings.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied, thanks.
Rob
> ---
> Documentation/devicetree/bindings/iio/accel/bma180.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/bma180.txt b/Documentation/devicetree/bindings/iio/accel/bma180.txt
> index c593357..4a3679d 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bma180.txt
> +++ b/Documentation/devicetree/bindings/iio/accel/bma180.txt
> @@ -1,10 +1,11 @@
> -* Bosch BMA180 triaxial acceleration sensor
> +* Bosch BMA180 / BMA250 triaxial acceleration sensor
>
> http://omapworld.com/BMA180_111_1002839.pdf
> +http://ae-bst.resource.bosch.com/media/products/dokumente/bma250/bst-bma250-ds002-05.pdf
>
> Required properties:
>
> - - compatible : should be "bosch,bma180"
> + - compatible : should be "bosch,bma180" or "bosch,bma250"
> - reg : the I2C address of the sensor
>
> Optional properties:
> @@ -13,6 +14,9 @@ Optional properties:
>
> - interrupts : interrupt mapping for GPIO IRQ, it should by configured with
> flags IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING
> + For the bma250 the first interrupt listed must be the one
> + connected to the INT1 pin, the second (optional) interrupt
> + listed must be the one connected to the INT2 pin.
>
> Example:
>
>
prev parent reply other threads:[~2015-09-17 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 10:52 [PATCH] devicetree: bindings: Extend the bma180 bindings with bma250 info Hans de Goede
2015-09-17 19:40 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FB1749.3050403@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hdegoede@redhat.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=plaes@plaes.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).