From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f46.google.com ([209.85.218.46]:34236 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbbIQTk7 (ORCPT ); Thu, 17 Sep 2015 15:40:59 -0400 Subject: Re: [PATCH] devicetree: bindings: Extend the bma180 bindings with bma250 info To: Hans de Goede References: <1442055169-16966-1-git-send-email-hdegoede@redhat.com> Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Cameron , Peter Meerwald , Maxime Ripard , plaes@plaes.org, linux-iio@vger.kernel.org, devicetree From: Rob Herring Message-ID: <55FB1749.3050403@kernel.org> Date: Thu, 17 Sep 2015 14:40:57 -0500 MIME-Version: 1.0 In-Reply-To: <1442055169-16966-1-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/12/2015 05:52 AM, Hans de Goede wrote: > The bma180 / bma250 accelerometers share a driver (at least under Linux), > so it makes sense to also have their bindings info in a single .txt. > > This commit extends the bma180 bindings with bma250 bindings, specifically > it specifies how the 2 seperate interrupts the bma250 has must be listed > in devicetree. The existing bma180 driver is already fully compatible > with the specified bindings. > > Signed-off-by: Hans de Goede Applied, thanks. Rob > --- > Documentation/devicetree/bindings/iio/accel/bma180.txt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/accel/bma180.txt b/Documentation/devicetree/bindings/iio/accel/bma180.txt > index c593357..4a3679d 100644 > --- a/Documentation/devicetree/bindings/iio/accel/bma180.txt > +++ b/Documentation/devicetree/bindings/iio/accel/bma180.txt > @@ -1,10 +1,11 @@ > -* Bosch BMA180 triaxial acceleration sensor > +* Bosch BMA180 / BMA250 triaxial acceleration sensor > > http://omapworld.com/BMA180_111_1002839.pdf > +http://ae-bst.resource.bosch.com/media/products/dokumente/bma250/bst-bma250-ds002-05.pdf > > Required properties: > > - - compatible : should be "bosch,bma180" > + - compatible : should be "bosch,bma180" or "bosch,bma250" > - reg : the I2C address of the sensor > > Optional properties: > @@ -13,6 +14,9 @@ Optional properties: > > - interrupts : interrupt mapping for GPIO IRQ, it should by configured with > flags IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING > + For the bma250 the first interrupt listed must be the one > + connected to the INT1 pin, the second (optional) interrupt > + listed must be the one connected to the INT2 pin. > > Example: > >