From: Jonathan Cameron <jic23@kernel.org>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Axel Lin <axel.lin@ingics.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF platform driver
Date: Sun, 20 Sep 2015 11:36:43 +0100 [thread overview]
Message-ID: <55FE8C3B.605@kernel.org> (raw)
In-Reply-To: <20150917170200.GA27396@goodgumbo.baconseed.org>
On 17/09/15 18:02, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Applied to the togreg branch of iio.git as I am treating these
as additions of functionality rather than explicit fixes.
I am guessing previous users didn't care about autoprobing
(and a lot of embedded systems don't use it). Hence it
can wait for the next merge window.
Thanks for clearing these up,
Jonathan
> ---
> drivers/iio/adc/twl6030-gpadc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index df12c57..becbb0a 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -875,6 +875,7 @@ static const struct of_device_id of_twl6030_match_tbl[] = {
> },
> { /* end */ }
> };
> +MODULE_DEVICE_TABLE(of, of_twl6030_match_tbl);
>
> static int twl6030_gpadc_probe(struct platform_device *pdev)
> {
>
prev parent reply other threads:[~2015-09-20 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 17:02 [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-20 10:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FE8C3B.605@kernel.org \
--to=jic23@kernel.org \
--cc=axel.lin@ingics.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).