* [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF platform driver
@ 2015-09-17 17:02 Luis de Bethencourt
2015-09-20 10:36 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-09-17 17:02 UTC (permalink / raw)
To: linux-kernel
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald, Axel Lin, linux-iio
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/iio/adc/twl6030-gpadc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index df12c57..becbb0a 100644
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -875,6 +875,7 @@ static const struct of_device_id of_twl6030_match_tbl[] = {
},
{ /* end */ }
};
+MODULE_DEVICE_TABLE(of, of_twl6030_match_tbl);
static int twl6030_gpadc_probe(struct platform_device *pdev)
{
--
2.4.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF platform driver
2015-09-17 17:02 [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-09-20 10:36 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-09-20 10:36 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald, Axel Lin,
linux-iio
On 17/09/15 18:02, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Applied to the togreg branch of iio.git as I am treating these
as additions of functionality rather than explicit fixes.
I am guessing previous users didn't care about autoprobing
(and a lot of embedded systems don't use it). Hence it
can wait for the next merge window.
Thanks for clearing these up,
Jonathan
> ---
> drivers/iio/adc/twl6030-gpadc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index df12c57..becbb0a 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -875,6 +875,7 @@ static const struct of_device_id of_twl6030_match_tbl[] = {
> },
> { /* end */ }
> };
> +MODULE_DEVICE_TABLE(of, of_twl6030_match_tbl);
>
> static int twl6030_gpadc_probe(struct platform_device *pdev)
> {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-20 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-17 17:02 [PATCH 1/2] iio: adc: twl6030-gpadc: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-20 10:36 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).