From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>, linux-iio@vger.kernel.org
Cc: Denis Ciocca <denis.ciocca@st.com>
Subject: Re: [RESEND PATCH 4/4] iio: st_common: use standard trigger suffix
Date: Sun, 20 Sep 2015 11:58:51 +0100 [thread overview]
Message-ID: <55FE916B.30006@kernel.org> (raw)
In-Reply-To: <1442303385-11905-1-git-send-email-linus.walleij@linaro.org>
On 15/09/15 08:49, Linus Walleij wrote:
> The triggers from ST sensors are named <iio_device_name>-trigger
> instead of the standard <iio_device_name>-dev<iio_dev_id> as
> used by most and also in the iio-tools. Change this to match
> the norm.
>
> After this I can do tests with generic_buffer -n <dev_name>
> without having to manually specify the trigger with the -t
> option.
>
> Cc: Denis Ciocca <denis.ciocca@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Sorry, I never replied to your last email about this one. Have
done so now as better to keep discussion in that thread than
start a new one.
Jonathan
> ---
> drivers/iio/common/st_sensors/st_sensors_trigger.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> index 3e907040c2c7..3c0aa17d753f 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
> @@ -24,7 +24,8 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
> int err;
> struct st_sensor_data *sdata = iio_priv(indio_dev);
>
> - sdata->trig = iio_trigger_alloc("%s-trigger", indio_dev->name);
> + sdata->trig = iio_trigger_alloc("%s-dev%d",
> + indio_dev->name, indio_dev->id);
> if (sdata->trig == NULL) {
> err = -ENOMEM;
> dev_err(&indio_dev->dev, "failed to allocate iio trigger.\n");
>
prev parent reply other threads:[~2015-09-20 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 7:49 [RESEND PATCH 4/4] iio: st_common: use standard trigger suffix Linus Walleij
2015-09-20 10:58 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FE916B.30006@kernel.org \
--to=jic23@kernel.org \
--cc=denis.ciocca@st.com \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).