From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Rosin <peda@lysator.liu.se>, linux-iio@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org
Subject: Re: Driver for Microchip digital potentiometers, v2
Date: Tue, 22 Sep 2015 10:16:07 +0200 [thread overview]
Message-ID: <56010E47.9070007@metafoo.de> (raw)
In-Reply-To: <1442870306-26128-1-git-send-email-peda@lysator.liu.se>
On 09/21/2015 11:18 PM, Peter Rosin wrote:
> From: Peter Rosin <peda@axentia.se>
>
> Hi!
>
> This is a new attempt for a driver for these chips. It is a
> complete rewrite since the first version which was a dirty
> misc driver (plagiarized from another misc driver) that got
> shredded in review.
Yeah, we need to move the ad_dpot driver over to IIO at some point. The main
issue is that we need to retain the old ABI (at least optionally).
> I don't know if I should have added a new unit "ohms", or if
> it is ok to only provide "steps"? One could also imagine that
> a digital pot can be used to implement a DAC, or something
> else, so maybe the actual unit should be somehow configurable?
Steps are the steps you make with your feet, so that wouldn't be the right
thing here. The right channel type is resistance and the unit is Ohm. You
can use a dpot for a lot of things, e.g. a LED, that doesn't mean we should
have the option to expose this device as a LED device. If something uses the
rdac to implement another function that should be a separate driver being
registered to the rdac.
prev parent reply other threads:[~2015-09-22 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 21:18 Driver for Microchip digital potentiometers, v2 Peter Rosin
2015-09-21 21:18 ` [PATCH v2] iio: mcp4xxx_dpot: Driver for Microchip digital potentiometers Peter Rosin
2015-09-22 7:27 ` Crt Mori
2015-09-22 7:42 ` Daniel Baluta
2015-09-22 12:10 ` Andreas Dannenberg
2015-09-22 8:16 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56010E47.9070007@metafoo.de \
--to=lars@metafoo.de \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peda@lysator.liu.se \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).