linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Rosin <peda@lysator.liu.se>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	Peter Rosin <peda@axentia.se>, Crt Mori <cmo@melexis.com>,
	Andreas Dannenberg <dannenberg@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] iio: resistance: Document that resistance can be output
Date: Tue, 22 Sep 2015 14:55:44 +0200	[thread overview]
Message-ID: <56014FD0.4010005@lysator.liu.se> (raw)
In-Reply-To: <CAEnQRZAcoqXMO7kYmK+PYcU7cNAtL8giuRqua4uRSP2hOegajw@mail.gmail.com>

On 2015-09-22 14:48, Daniel Baluta wrote:
> On Tue, Sep 22, 2015 at 3:39 PM, Peter Rosin <peda@lysator.liu.se> wrote:
>> From: Peter Rosin <peda@axentia.se>
>>
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>>  Documentation/ABI/testing/sysfs-bus-iio |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index 9398484196c4..2eea468f704d 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1475,6 +1475,8 @@ Description:
>>
>>  What:          /sys/bus/iio/devices/iio:deviceX/in_resistance_raw
>>  What:          /sys/bus/iio/devices/iio:deviceX/in_resistanceX_raw
>> +What:          /sys/bus/iio/devices/iio:deviceX/out_resistance_raw
>> +What:          /sys/bus/iio/devices/iio:deviceX/out_resistanceX_raw
>>  KernelVersion: 4.3
>>  Contact:       linux-iio@vger.kernel.org
>>  Description:
> 
> One more thing. The description for this sections says:
> 
> »       »       Raw (unscaled no offset etc.) resistance reading that
> can be processed
> »       »       into an ohm value.
> 
> I'm not sure this still holds for out_resistanceX_raw. We have two options here:

I figured it did hold, since you effectively select what reading the
resistance inside the potentiometer should have. If it's really
important I can of course make another spin, but is this somthing
that is likely to be misunderstood?

> * remove 'reading' because with the out_ file we are basically setting
> the resistance
> raw value OR
> * add a separate section for out_ files, with proper description.
> 
> Any other comments?
> 
> thanks,
> Daniel.
> 

  reply	other threads:[~2015-09-22 12:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 12:39 [PATCH v3 0/2] Driver for Microchip digital potentiometers Peter Rosin
2015-09-22 12:39 ` [PATCH v3 1/2] iio: resistance: Document that resistance can be output Peter Rosin
2015-09-22 12:48   ` Daniel Baluta
2015-09-22 12:55     ` Peter Rosin [this message]
2015-09-22 12:59       ` Daniel Baluta
2015-09-22 12:39 ` [PATCH v3 2/2] iio: mcp4531: Driver for Microchip digital potentiometers Peter Rosin
2015-09-22 13:01   ` Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56014FD0.4010005@lysator.liu.se \
    --to=peda@lysator.liu.se \
    --cc=cmo@melexis.com \
    --cc=daniel.baluta@gmail.com \
    --cc=dannenberg@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).