From: Lars-Peter Clausen <lars@metafoo.de>
To: Hugo Camboulive <hugo.camboulive@gmail.com>,
Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: adc: fix comment block coding style issue
Date: Sun, 04 Oct 2015 13:57:39 +0200 [thread overview]
Message-ID: <56111433.4090904@metafoo.de> (raw)
In-Reply-To: <1443897168-5591-1-git-send-email-hugo.camboulive@gmail.com>
On 10/03/2015 08:32 PM, Hugo Camboulive wrote:
> This patch to ad7746.c makes the comment block end with a */
> on a separate line.
>
> Signed-off-by: Hugo Camboulive <hugo.camboulive@gmail.com>
> ---
> drivers/staging/iio/cdc/ad7746.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 10fa372..8445ddd 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -531,7 +531,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev,
> /* CAPDAC Scale = 21pF_typ / 127
> * CIN Scale = 8.192pF / 2^24
> * Offset Scale = CAPDAC Scale / CIN Scale = 338646
> - * */
> + */
Looks good, but while you are at it please also fix the beginning of the
comment. Kernel style multi-line comments look like
/*
* text
* more text
*/
So the line with the /* should have any text.
Bonus points if you can also fix all other occurrences of this style error
in the same file.
- Lars
next prev parent reply other threads:[~2015-10-04 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 18:32 [PATCH] staging: iio: adc: fix comment block coding style issue Hugo Camboulive
2015-10-04 11:57 ` Lars-Peter Clausen [this message]
2015-10-04 16:30 ` [PATCH v2] " Hugo Camboulive
2015-10-04 14:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56111433.4090904@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo.camboulive@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).