From: Jonathan Cameron <jic23@kernel.org>
To: Hugo Camboulive <hugo.camboulive@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: iio: adc: fix comment block coding style issue
Date: Sun, 4 Oct 2015 15:39:52 +0100 [thread overview]
Message-ID: <56113A38.30709@kernel.org> (raw)
In-Reply-To: <1443976245-869-1-git-send-email-hugo.camboulive@gmail.com>
On 04/10/15 17:30, Hugo Camboulive wrote:
> This patch to ad7746.c makes the comment blocks end with a */
> on a separate line, and start with a /* on an empty line.
>
> Signed-off-by: Hugo Camboulive <hugo.camboulive@gmail.com>
Thanks.
Applied to the togreg branch of iio.git - initially pushed out
as staging for the automated build testing to check it.
(obviously not really going to do much with this patch!)
Probably a good few more of these in the staging drivers if
you want to clear out a few more!
If not, take a look at the review I did of this driver the other
day for other bits that could do with cleaning up.
http://marc.info/?l=linux-iio&m=144277958123939&w=2
> ---
> drivers/staging/iio/cdc/ad7746.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 10fa372..e8eab25 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -528,10 +528,11 @@ static int ad7746_write_raw(struct iio_dev *indio_dev,
> goto out;
> }
>
> - /* CAPDAC Scale = 21pF_typ / 127
> + /*
> + * CAPDAC Scale = 21pF_typ / 127
> * CIN Scale = 8.192pF / 2^24
> * Offset Scale = CAPDAC Scale / CIN Scale = 338646
> - * */
> + */
>
> val /= 338646;
>
> @@ -600,7 +601,8 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
>
> switch (chan->type) {
> case IIO_TEMP:
> - /* temperature in milli degrees Celsius
> + /*
> + * temperature in milli degrees Celsius
> * T = ((*val / 2048) - 4096) * 1000
> */
> *val = (*val * 125) / 256;
>
prev parent reply other threads:[~2015-10-04 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 18:32 [PATCH] staging: iio: adc: fix comment block coding style issue Hugo Camboulive
2015-10-04 11:57 ` Lars-Peter Clausen
2015-10-04 16:30 ` [PATCH v2] " Hugo Camboulive
2015-10-04 14:39 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56113A38.30709@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo.camboulive@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).