linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: "linux-iio @ vger . kernel . org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: bmc150: Fix type of step transfer variable
Date: Sun, 11 Oct 2015 10:32:02 +0100	[thread overview]
Message-ID: <561A2C92.5060006@kernel.org> (raw)
In-Reply-To: <1444156299-14316-1-git-send-email-mpa@pengutronix.de>

On 06/10/15 19:31, Markus Pargmann wrote:
> regmap_get_raw_read_max() returns type size_t. Also the later dev_err()
> already uses the correct printk format "%zu".
> 
> This patch changes the type of 'step' to size_t.
> 
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> Hi,
> 
> this problem was reported by the kbuild robot. This should fix the warning. I
> am not sure if the patches are already in some public tree, otherwise this
> could directly be squashed into the commit directly.
> 
> Thanks,
> 
> Markus
I'm not sure what happened here.  I haven't touched the tree since this report,
but the type is already size_t in my local tree. 

Anyhow, the issues seems not to exist anymore for some reason.

J
> 
> 
>  drivers/iio/accel/bmc150-accel-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
> index 614cf61f0110..dc89cf8b7603 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -891,7 +891,7 @@ static int bmc150_accel_fifo_transfer(struct bmc150_accel_data *data,
>  	int ret;
>  	int total_length = samples * sample_length;
>  	int i;
> -	int step = regmap_get_raw_read_max(data->regmap);
> +	size_t step = regmap_get_raw_read_max(data->regmap);
>  
>  	if (!step || step > total_length)
>  		step = total_length;
> 


      reply	other threads:[~2015-10-11  9:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201510032331.iV9fviPZ%fengguang.wu@intel.com>
2015-10-06 18:31 ` [PATCH] iio: bmc150: Fix type of step transfer variable Markus Pargmann
2015-10-11  9:32   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561A2C92.5060006@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).