linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Marek Vasut <marex@denx.de>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: mxs-lradc: Fix temperature offset
Date: Sun, 11 Oct 2015 15:03:26 +0100	[thread overview]
Message-ID: <561A6C2E.4080800@kernel.org> (raw)
In-Reply-To: <561455AC.60504@denx.de>

On 07/10/15 00:13, Marek Vasut wrote:
> On 10/06/2015 16:22, Alexandre Belloni wrote:
>> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.
>>
>> Reported-by: Janusz Użycki <j.uzycki@elpromaelectronics.com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> 
> Nice find :-)
> 
> Acked-by: Marek Vasut <marex@denx.de>
Ah, missed this when applying.  Have added your Ack to the V2 and will
push it out later.

J
> 
> (I am using different MUA, please pardon the possible issues)
> 
>> ---
>>   drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
>> index 3f7715c9968b..67bfa54c4fb1 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>>           if (chan->type == IIO_TEMP) {
>>               /* The calculated value from the ADC is in Kelvin, we
>>                * want Celsius for hwmon so the offset is
>> -             * -272.15 * scale
>> +             * -273.15 * scale
>>                */
>> -            *val = -1075;
>> -            *val2 = 691699;
>> +            *val = -1079;
>> +            *val2 = 644268;
>>
>>               return IIO_VAL_INT_PLUS_MICRO;
>>           }
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2015-10-11 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 14:22 [PATCH] iio: mxs-lradc: Fix temperature offset Alexandre Belloni
2015-10-06 18:43 ` Stefan Wahren
2015-10-06 23:19   ` Marek Vasut
2015-10-07  0:44     ` Alexandre Belloni
2015-10-07  7:12       ` Stefan Wahren
2015-10-08 21:12         ` Marek Vasut
2015-10-06 23:13 ` Marek Vasut
2015-10-11 14:03   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561A6C2E.4080800@kernel.org \
    --to=jic23@kernel.org \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).