linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Hartmut Knaack <knaack.h@gmx.de>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Subject: Re: [PATCH 1/6] iio:dac:m62332: share scale and offset
Date: Sun, 11 Oct 2015 15:40:12 +0100	[thread overview]
Message-ID: <561A74CC.8070103@kernel.org> (raw)
In-Reply-To: <1d2903d19cf988620b155b16ea58dd13d392f598.1440459082.git.knaack.h@gmx.de>

On 28/08/15 22:59, Hartmut Knaack wrote:
> This device simply uses its Vcc as reference voltage, so the same scale
> applies for all channels. Also offset doesn't appear to be different for
> any channel. Represent this by switching these two attributes to
> info_mask_shared_by_type.
> 
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
Applied to the togreg branch of iio.git.

Thanks,

Jonathan
> ---
> Hope you don't mind too much, that I inserted an extra tab in the whole
> block rather than messing up style and cleaning it up later.
> 
>  drivers/iio/dac/m62332.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/dac/m62332.c b/drivers/iio/dac/m62332.c
> index c23d7fa889ee..cffc0630ed32 100644
> --- a/drivers/iio/dac/m62332.c
> +++ b/drivers/iio/dac/m62332.c
> @@ -173,15 +173,15 @@ static const struct iio_info m62332_info = {
>  	.driver_module = THIS_MODULE,
>  };
>  
> -#define M62332_CHANNEL(chan) {				\
> -	.type = IIO_VOLTAGE,				\
> -	.indexed = 1,					\
> -	.output = 1,					\
> -	.channel = (chan),				\
> -	.datasheet_name = "CH" #chan,			\
> -	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |	\
> -		BIT(IIO_CHAN_INFO_SCALE) |		\
> -		BIT(IIO_CHAN_INFO_OFFSET),		\
> +#define M62332_CHANNEL(chan) {					\
> +	.type = IIO_VOLTAGE,					\
> +	.indexed = 1,						\
> +	.output = 1,						\
> +	.channel = (chan),					\
> +	.datasheet_name = "CH" #chan,				\
> +	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),		\
> +	.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |	\
> +				    BIT(IIO_CHAN_INFO_OFFSET),	\
>  }
>  
>  static const struct iio_chan_spec m62332_channels[M62332_CHANNELS] = {
> 


  parent reply	other threads:[~2015-10-11 14:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 21:59 [PATCH 0/6] fixes, cleanup and improvements for m62332 Hartmut Knaack
2015-08-28 21:59 ` [PATCH 1/6] iio:dac:m62332: share scale and offset Hartmut Knaack
2015-08-31 14:53   ` Jonathan Cameron
2015-09-12 10:11     ` Jonathan Cameron
2015-09-12 10:14       ` Jonathan Cameron
2015-09-27 15:56         ` Jonathan Cameron
2015-10-11 14:40   ` Jonathan Cameron [this message]
2015-08-28 21:59 ` [PATCH 2/6] iio:dac:m62332: shutdown on remove Hartmut Knaack
2015-08-31 12:56   ` Daniel Baluta
2015-08-31 19:26     ` Hartmut Knaack
2015-10-11 14:42     ` Jonathan Cameron
2015-08-28 21:59 ` [PATCH 3/6] iio:dac:m62332: use ARRAY_SIZE Hartmut Knaack
2015-08-31 12:58   ` Daniel Baluta
2015-10-11 14:43     ` Jonathan Cameron
2015-08-28 21:59 ` [PATCH 4/6] iio:dac:m62332: drop unrequired variable Hartmut Knaack
2015-08-31 19:46   ` Daniel Baluta
2015-10-11 14:44     ` Jonathan Cameron
2015-08-28 21:59 ` [PATCH 5/6] iio:dac:m62332: address some style issues Hartmut Knaack
2015-10-11 14:45   ` Jonathan Cameron
2015-08-28 21:59 ` [PATCH 6/6] iio:dac:m62332: use dynamic scale Hartmut Knaack
2015-10-11 14:46   ` Jonathan Cameron
2015-08-31 15:00 ` [PATCH 0/6] fixes, cleanup and improvements for m62332 Jonathan Cameron
2015-08-31 16:09   ` Dmitry Eremin-Solenikov
2015-09-12 10:13     ` Jonathan Cameron
2015-10-03 11:16       ` Jonathan Cameron
2015-10-11 14:38         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561A74CC.8070103@kernel.org \
    --to=jic23@kernel.org \
    --cc=dbaryshkov@gmail.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).