From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:41773 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbbJKOkO (ORCPT ); Sun, 11 Oct 2015 10:40:14 -0400 Subject: Re: [PATCH 1/6] iio:dac:m62332: share scale and offset To: Hartmut Knaack , linux-iio@vger.kernel.org References: <1d2903d19cf988620b155b16ea58dd13d392f598.1440459082.git.knaack.h@gmx.de> Cc: Lars-Peter Clausen , Peter Meerwald , Dmitry Eremin-Solenikov From: Jonathan Cameron Message-ID: <561A74CC.8070103@kernel.org> Date: Sun, 11 Oct 2015 15:40:12 +0100 MIME-Version: 1.0 In-Reply-To: <1d2903d19cf988620b155b16ea58dd13d392f598.1440459082.git.knaack.h@gmx.de> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 28/08/15 22:59, Hartmut Knaack wrote: > This device simply uses its Vcc as reference voltage, so the same scale > applies for all channels. Also offset doesn't appear to be different for > any channel. Represent this by switching these two attributes to > info_mask_shared_by_type. > > Signed-off-by: Hartmut Knaack Applied to the togreg branch of iio.git. Thanks, Jonathan > --- > Hope you don't mind too much, that I inserted an extra tab in the whole > block rather than messing up style and cleaning it up later. > > drivers/iio/dac/m62332.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/iio/dac/m62332.c b/drivers/iio/dac/m62332.c > index c23d7fa889ee..cffc0630ed32 100644 > --- a/drivers/iio/dac/m62332.c > +++ b/drivers/iio/dac/m62332.c > @@ -173,15 +173,15 @@ static const struct iio_info m62332_info = { > .driver_module = THIS_MODULE, > }; > > -#define M62332_CHANNEL(chan) { \ > - .type = IIO_VOLTAGE, \ > - .indexed = 1, \ > - .output = 1, \ > - .channel = (chan), \ > - .datasheet_name = "CH" #chan, \ > - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > - BIT(IIO_CHAN_INFO_SCALE) | \ > - BIT(IIO_CHAN_INFO_OFFSET), \ > +#define M62332_CHANNEL(chan) { \ > + .type = IIO_VOLTAGE, \ > + .indexed = 1, \ > + .output = 1, \ > + .channel = (chan), \ > + .datasheet_name = "CH" #chan, \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ > + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) | \ > + BIT(IIO_CHAN_INFO_OFFSET), \ > } > > static const struct iio_chan_spec m62332_channels[M62332_CHANNELS] = { >