From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio:ad7793: Fix ad7785 product ID
Date: Sun, 25 Oct 2015 13:40:25 +0000 [thread overview]
Message-ID: <562CDBC9.9090409@kernel.org> (raw)
In-Reply-To: <1444654588-25350-1-git-send-email-lars@metafoo.de>
On 12/10/15 13:56, Lars-Peter Clausen wrote:
> While the datasheet for the AD7785 lists 0xXB as the product ID the actual
> product ID is 0xX3.
>
> Fix the product ID otherwise the driver will reject the device due to non
> matching IDs.
>
> Fixes: e786cc26dcc5 ("staging:iio:ad7793: Implement stricter id checking")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the fixes-togreg branch of iio.git and marked for stable.
> ---
> drivers/iio/adc/ad7793.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index b84922a..710aee8 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -101,7 +101,7 @@
> #define AD7795_CH_AIN1M_AIN1M 8 /* AIN1(-) - AIN1(-) */
>
> /* ID Register Bit Designations (AD7793_REG_ID) */
> -#define AD7785_ID 0xB
> +#define AD7785_ID 0x3
> #define AD7792_ID 0xA
> #define AD7793_ID 0xB
> #define AD7794_ID 0xF
>
prev parent reply other threads:[~2015-10-25 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 12:56 [PATCH] iio:ad7793: Fix ad7785 product ID Lars-Peter Clausen
2015-10-25 13:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562CDBC9.9090409@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).