From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: generic_buffer.c bug
Date: Sat, 31 Oct 2015 10:43:49 +0000 [thread overview]
Message-ID: <56349B65.3010201@kernel.org> (raw)
In-Reply-To: <CAKzfze8JuNGf4NEZJxP0X3UQ21FubYgyB8da7FQSv_dK9cuk8Q@mail.gmail.com>
On 28/10/15 05:26, Matt Ranostay wrote:
> Jonathan et all,
>
> Well actually this issues is in the build_channel_array function
> located in iio_utils.c, but when testing my LIDAR driver with the
> generic_buffer tool I found the following corner case.
>
> So in_distance_* has a scale entry but no offset so it in turn it
> fails.. at line 495 in iio_utils.c
This is odd. That line currently contains:
if ((ret < 0) && (ret != -ENOENT))
The -ENOENT bit is there to deal with the file not existing.
Any chance you are using a version prior to the fix that added the
ENOENT check?
7868dfd216074fc5f902e7befacda2a0ec76e403
tools: iio: make scale and offset files optional
from back on July.
There was a window in which it was broken prior to that.
Jonathan
>
> Thanks,
>
> Matt
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-10-31 10:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 5:26 generic_buffer.c bug Matt Ranostay
2015-10-31 10:43 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56349B65.3010201@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mranostay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox