Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net,
	Michael.Hennerich@analog.com
Subject: Re: [PATCH] iio:dac: fix i2c_master_send return code misuse
Date: Sun, 8 Nov 2015 15:10:57 +0000	[thread overview]
Message-ID: <563F6601.2030309@kernel.org> (raw)
In-Reply-To: <DA5D8A05-2B37-441E-804B-C73BCBE8628C@gmail.com>

On 08/11/15 14:10, Jean-Francois Dagenais wrote:
> 
>> On Nov 8, 2015, at 8:28 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>>
>>> Fell through the cracks I'm afraid. I think facility like this is still
>>> needed as majority of the drivers do not care about short reads in the
>>> slightest.
>>>
>> Would be great to pick it up again if you have the time!
>>
> 
> Certainly, the i2c chips handled by ad5446.c do no function at all with the
> current state of the driver!
> 
> I can resubmit a patch only for ad5446.c or wait for Dmitry's patch to be
> applied, then make the proper change in ad5446.c.
> 
> For now, our own tree contains my original patch, so we're good... thank you
> open source!
Where things are actually broken we'll want the fix in stable kernel
trees so ideally we'll have the following:

1) Your current fix applied asap marked for stable.
2) Dmitry's patch resurfaces and allows us to follow up in a cycle or so with
cleanups that move every case over to that, hopefully avoiding any further repeats
of this problem!

If you can role a response to the point Lars raised and send an updated series
that would be great.  Next set of fixes to head towards mainline will be next
weekend at the earliest anyway so we have a bit of time to tidy up!

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


      reply	other threads:[~2015-11-08 15:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 16:25 iio:dac: fix i2c_master_send return code misuse Jean-Francois Dagenais
2015-10-27 16:25 ` [PATCH] " Jean-Francois Dagenais
2015-10-27 16:34   ` Jean-François Dagenais
2015-10-31 11:00   ` Jonathan Cameron
2015-11-03 14:27   ` Lars-Peter Clausen
2015-11-04  1:10     ` Dmitry Torokhov
2015-11-08 13:28       ` Jonathan Cameron
2015-11-08 14:10         ` Jean-Francois Dagenais
2015-11-08 15:10           ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563F6601.2030309@kernel.org \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jeff.dagenais@gmail.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox