Re: [PATCH] iio: light: apds9960: correct ->last_busy count

[Jonathan Cameron <jic23@kernel.org>]

On 08/11/15 04:21, Matt Ranostay wrote:
> Add missing pm_runtime_mark_last_busy to apds9960_set_power_state
> function.
> 
> Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Hi Matt,

Could you elaborate on what the result of this not being there is? 
My first thought is that this probably wants to go as a fix, but for
that I need details of what the effects of the 'bug' are.

Jonathan
> ---
>  drivers/iio/light/apds9960.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index 7d269ef..f6a07dc 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -453,6 +453,7 @@ static int apds9960_set_power_state(struct apds9960_data *data, bool on)
>  			usleep_range(data->als_adc_int_us,
>  				     APDS9960_MAX_INT_TIME_IN_US);
>  	} else {
> +		pm_runtime_mark_last_busy(dev);
>  		ret = pm_runtime_put_autosuspend(dev);
>  	}
>  
>