* [PATCH 3/7] iio: fix a problematic usage of WARN_ON()
[not found] ` <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com>
@ 2015-11-25 13:12 ` Geliang Tang
2015-11-25 13:14 ` Lars-Peter Clausen
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2015-11-25 13:12 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald
Cc: Geliang Tang, linux-iio, linux-kernel
WARN_ON() takes a condition rather than a format string. This patch
converted WARN_ON() to WARN() instead.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
drivers/iio/industrialio-buffer.c | 2 +-
drivers/iio/industrialio-core.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index d7e908a..0f6f63b 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -302,7 +302,7 @@ static int iio_scan_mask_set(struct iio_dev *indio_dev,
if (trialmask == NULL)
return -ENOMEM;
if (!indio_dev->masklength) {
- WARN_ON("Trying to set scanmask prior to registering buffer\n");
+ WARN(1, "Trying to set scanmask prior to registering buffer\n");
goto err_invalid_mask;
}
bitmap_copy(trialmask, buffer->scan_mask, indio_dev->masklength);
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 37697d5..fe80366 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -654,7 +654,7 @@ int __iio_device_attr_init(struct device_attribute *dev_attr,
break;
case IIO_SEPARATE:
if (!chan->indexed) {
- WARN_ON("Differential channels must be indexed\n");
+ WARN(1, "Differential channels must be indexed\n");
ret = -EINVAL;
goto error_free_full_postfix;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/7] iio: fix a problematic usage of WARN_ON()
2015-11-25 13:12 ` [PATCH 3/7] iio: fix a problematic usage of WARN_ON() Geliang Tang
@ 2015-11-25 13:14 ` Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2015-11-25 13:14 UTC (permalink / raw)
To: Geliang Tang, Jonathan Cameron, Hartmut Knaack, Peter Meerwald
Cc: linux-iio, linux-kernel
On 11/25/2015 02:12 PM, Geliang Tang wrote:
> WARN_ON() takes a condition rather than a format string. This patch
> converted WARN_ON() to WARN() instead.
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>
Thanks for the patch, the issue was already fixed a few days ago.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-25 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <86c73f180d3054c1bf17bdac8c89026209167c9b.1448456395.git.geliangtang@163.com>
[not found] ` <8bb789c0803579a01e1ee977ed67408c422acd79.1448456395.git.geliangtang@163.com>
2015-11-25 13:12 ` [PATCH 3/7] iio: fix a problematic usage of WARN_ON() Geliang Tang
2015-11-25 13:14 ` Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).