From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:56139 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbbLLO57 (ORCPT ); Sat, 12 Dec 2015 09:57:59 -0500 Subject: Re: [PATCH 1/3] iio: light: us5182d: Fix enable status inconcistency To: Adriana Reus References: <1449661244-18692-1-git-send-email-adriana.reus@intel.com> <1449661244-18692-2-git-send-email-adriana.reus@intel.com> Cc: linux-iio@vger.kernel.org From: Jonathan Cameron Message-ID: <566C35F3.408@kernel.org> Date: Sat, 12 Dec 2015 14:57:55 +0000 MIME-Version: 1.0 In-Reply-To: <1449661244-18692-2-git-send-email-adriana.reus@intel.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 09/12/15 11:40, Adriana Reus wrote: > When setting als only or proximity only modes make sure that we mark the other > component as disabled. > > Signed-off-by: Adriana Reus Hi Adriana When you send a fix of any type, please describe the effects of the bug. That way I have more information to figure out if the bug is tidying up a loose end or fixing a critical bug and hence judge which path it takes to upstream. Please let me know for this one as I can't immediately pick out what the effects will be. Jonathan > --- > drivers/iio/light/us5182d.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c > index 256c4bc..f24b687 100644 > --- a/drivers/iio/light/us5182d.c > +++ b/drivers/iio/light/us5182d.c > @@ -238,8 +238,12 @@ static int us5182d_als_enable(struct us5182d_data *data) > int ret; > u8 mode; > > - if (data->power_mode == US5182D_ONESHOT) > - return us5182d_set_opmode(data, US5182D_ALS_ONLY); > + if (data->power_mode == US5182D_ONESHOT) { > + ret = us5182d_set_opmode(data, US5182D_ALS_ONLY); > + if (ret < 0) > + return ret; > + data->px_enabled = false; > + } > > if (data->als_enabled) > return 0; > @@ -260,8 +264,12 @@ static int us5182d_px_enable(struct us5182d_data *data) > int ret; > u8 mode; > > - if (data->power_mode == US5182D_ONESHOT) > - return us5182d_set_opmode(data, US5182D_PX_ONLY); > + if (data->power_mode == US5182D_ONESHOT) { > + ret = us5182d_set_opmode(data, US5182D_PX_ONLY); > + if (ret < 0) > + return ret; > + data->als_enabled = false; > + } > > if (data->px_enabled) > return 0; >