Linux IIO development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marco Felsch <m.felsch@pengutronix.de>,
	puranjay12@gmail.com, jic23@kernel.org, lars@metafoo.de,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v3 2/4] dt-bindings: iio: ti,tmp117: add binding for the TMP116
Date: Mon, 20 Feb 2023 09:02:43 +0100	[thread overview]
Message-ID: <56826d1d-50c9-4bce-3197-6ecc3efbe51e@linaro.org> (raw)
In-Reply-To: <20230217093711.1891564-3-m.felsch@pengutronix.de>

On 17/02/2023 10:37, Marco Felsch wrote:
> The TMP116 is the predecessor of the TMP117.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> v3:
> - don't use tmp117 as fallback, therefore I didn't add Krzysztof
>   rb.
> v2:
> - drop items from single enum
> 
>  .../devicetree/bindings/iio/temperature/ti,tmp117.yaml      | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> index 8d1ec4d39b28c..a2f647fe0760c 100644
> --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml
> @@ -7,8 +7,9 @@ $schema: "http://devicetree.org/meta-schemas/core.yaml#"
>  title: "TI TMP117 - Digital temperature sensor with integrated NV memory"
>  
>  description: |
> -    TI TMP117 - Digital temperature sensor with integrated NV memory that supports
> -    I2C interface.
> +    TI TMP116/117 - Digital temperature sensor with integrated NV memory that
> +    supports I2C interface.
> +      https://www.ti.com/lit/gpn/tmp116
>        https://www.ti.com/lit/gpn/tmp117
>  
>  maintainers:
> @@ -18,6 +19,7 @@ properties:
>    compatible:
>      enum:
>        - ti,tmp117
> +      - ti,tmp116

Don't add entries to the end, but keep some order. Less conflicts.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2023-02-20  8:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17  9:37 [PATCH v3 0/4] Add TI TMP116 Support Marco Felsch
2023-02-17  9:37 ` [PATCH v3 1/4] dt-bindings: iio: ti,tmp117: fix documentation link Marco Felsch
2023-02-17  9:37 ` [PATCH v3 2/4] dt-bindings: iio: ti,tmp117: add binding for the TMP116 Marco Felsch
2023-02-20  8:02   ` Krzysztof Kozlowski [this message]
2023-02-17  9:37 ` [PATCH v3 3/4] iio: temperature: tmp117: add TI TMP116 support Marco Felsch
2023-02-18 17:04   ` Jonathan Cameron
2023-02-17  9:37 ` [PATCH v3 4/4] iio: temperature: tmp117: cosmetic alignment cleanup Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56826d1d-50c9-4bce-3197-6ecc3efbe51e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=puranjay12@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox