From: Jonathan Cameron <jic23@kernel.org>
To: Yong Li <sdliyong@gmail.com>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
akinobu.mita@gmail.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: mcp4725: set iio name property in sysfs
Date: Sat, 9 Jan 2016 16:35:00 +0000 [thread overview]
Message-ID: <569136B4.306@kernel.org> (raw)
In-Reply-To: <1452042583-10580-1-git-send-email-sdliyong@gmail.com>
On 06/01/16 01:09, Yong Li wrote:
> Without this change, the name entity for mcp4725 is missing in
> /sys/bus/iio/devices/iio\:device*/name
>
> With this change, name is reported correctly
>
> Signed-off-by: Yong Li <sdliyong@gmail.com>
Hi Yong,
A fix like this gets applied to the iio fixes-togreg branch
and this one required a bit of pushing to get it to apply.
I've marked it for stable as well.
Thanks!
Jonathan
> ---
> drivers/iio/dac/mcp4725.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
> index fb4b336..cca935c 100644
> --- a/drivers/iio/dac/mcp4725.c
> +++ b/drivers/iio/dac/mcp4725.c
> @@ -346,6 +346,7 @@ static int mcp4725_probe(struct i2c_client *client,
> data->client = client;
>
> indio_dev->dev.parent = &client->dev;
> + indio_dev->name = id->name;
> indio_dev->info = &mcp4725_info;
> indio_dev->channels = &mcp472x_channel[id->driver_data];
> indio_dev->num_channels = 1;
>
prev parent reply other threads:[~2016-01-09 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 1:09 [PATCH] iio: dac: mcp4725: set iio name property in sysfs Yong Li
2016-01-09 16:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569136B4.306@kernel.org \
--to=jic23@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sdliyong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).