From: Jonathan Cameron <jic23@kernel.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] iio: add ad5761 DAC driver
Date: Mon, 11 Jan 2016 19:28:17 +0000 [thread overview]
Message-ID: <56940251.10306@kernel.org> (raw)
In-Reply-To: <CAPybu_1sOxX9_zr7ujhhXxZvH4=8c5VUU-6kAEiynan_K-x6OA@mail.gmail.com>
On 11/01/16 19:26, Ricardo Ribalda Delgado wrote:
> Hello Jonathan
>
> On Mon, Jan 11, 2016 at 8:24 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 11/01/16 16:23, Ricardo Ribalda Delgado wrote:
>>> ad5761 is a 1-channel DAC with configurable output range.
>>> The driver uses the regulator interface for its voltage ref.
>>>
>>> It shares its register layout with ad5761r, ad5721 and ad5721r.
>>>
>>> Differences:
>>> ad5761* are 16 bit, ad5721* are 12 bits.
>>> ad57*1r have an internal reference.
>>>
>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> Just that unnecessary null check left as far as I'm concerned.
>> I'd like to leave this a little while for others to take a look
>> if they like as well.
>
> Shall i send v7 with that fixed or I wait?
Up to you. I doubt it will hold others back from commenting, but then
they might not comment and you'll have to remember to send it in a couple
of days....
>
>
> Regards!
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2016-01-11 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 16:23 [PATCH v6] iio: add ad5761 DAC driver Ricardo Ribalda Delgado
2016-01-11 19:24 ` Jonathan Cameron
2016-01-11 19:26 ` Ricardo Ribalda Delgado
2016-01-11 19:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56940251.10306@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).