From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:50517 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932953AbcAKT2T (ORCPT ); Mon, 11 Jan 2016 14:28:19 -0500 Subject: Re: [PATCH v6] iio: add ad5761 DAC driver To: Ricardo Ribalda Delgado References: <1452529385-20940-1-git-send-email-ricardo.ribalda@gmail.com> <5694017C.2050507@kernel.org> Cc: Lars-Peter Clausen , Michael Hennerich , Hartmut Knaack , Peter Meerwald , linux-iio@vger.kernel.org, LKML From: Jonathan Cameron Message-ID: <56940251.10306@kernel.org> Date: Mon, 11 Jan 2016 19:28:17 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 11/01/16 19:26, Ricardo Ribalda Delgado wrote: > Hello Jonathan > > On Mon, Jan 11, 2016 at 8:24 PM, Jonathan Cameron wrote: >> On 11/01/16 16:23, Ricardo Ribalda Delgado wrote: >>> ad5761 is a 1-channel DAC with configurable output range. >>> The driver uses the regulator interface for its voltage ref. >>> >>> It shares its register layout with ad5761r, ad5721 and ad5721r. >>> >>> Differences: >>> ad5761* are 16 bit, ad5721* are 12 bits. >>> ad57*1r have an internal reference. >>> >>> Signed-off-by: Ricardo Ribalda Delgado >> Just that unnecessary null check left as far as I'm concerned. >> I'd like to leave this a little while for others to take a look >> if they like as well. > > Shall i send v7 with that fixed or I wait? Up to you. I doubt it will hold others back from commenting, but then they might not comment and you'll have to remember to send it in a couple of days.... > > > Regards! > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >