From: Lars-Peter Clausen <lars@metafoo.de>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] iio: add ad5761 DAC driver
Date: Mon, 11 Jan 2016 22:05:36 +0100 [thread overview]
Message-ID: <56941920.8020406@metafoo.de> (raw)
In-Reply-To: <1452540774-26410-1-git-send-email-ricardo.ribalda@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]
On 01/11/2016 08:32 PM, Ricardo Ribalda Delgado wrote:
> ad5761 is a 1-channel DAC with configurable output range.
> The driver uses the regulator interface for its voltage ref.
>
> It shares its register layout with ad5761r, ad5721 and ad5721r.
>
> Differences:
> ad5761* are 16 bit, ad5721* are 12 bits.
> ad57*1r have an internal reference.
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Looks very clean now, thanks. I have just one comment I overlooked during
the first review. When that's addresses feel free to add
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
And one wish for the future, please give people a chance a review and don't
resend a new version of the patch every couple of hours. This will make the
reviewers life a bit easier.
> diff --git a/include/linux/iio/dac/ad5761.h b/include/linux/iio/dac/ad5761.h
> new file mode 100644
> index 000000000000..2f3702309d61
> --- /dev/null
> +++ b/include/linux/iio/dac/ad5761.h
This should go into include/linux/platform_data. That's where all new
platform data include files should go.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-12 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 19:32 [PATCH v7] iio: add ad5761 DAC driver Ricardo Ribalda Delgado
2016-01-11 21:05 ` Lars-Peter Clausen [this message]
2016-01-12 8:23 ` Ricardo Ribalda Delgado
2016-01-16 12:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56941920.8020406@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).