From: Jonathan Cameron <jic23@kernel.org>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: "Marek Vasut" <marex@denx.de>, "Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Martin Liška" <marxin.liska@gmail.com>,
linux-iio@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: light: acpi-als: Report data as processed rather than raw
Date: Sat, 16 Jan 2016 12:57:04 +0000 [thread overview]
Message-ID: <569A3E20.9080707@kernel.org> (raw)
In-Reply-To: <CABFtUbRT2bWsUCn6sCxytZDoAV5hC9rojpJUwXJrt2EEXyCSVA@mail.gmail.com>
On 12/01/16 15:27, Gabriele Mazzotta wrote:
> 2016-01-11 20:18 GMT+01:00 Jonathan Cameron <jic23@kernel.org>:
>> On 09/01/16 17:27, Marek Vasut wrote:
>>> On Saturday, January 09, 2016 at 05:31:24 PM, Jonathan Cameron wrote:
>>>> On 07/01/16 15:21, Gabriele Mazzotta wrote:
>>>>> As per the ACPI specification (Revision 5.0) [1], the data coming
>>>>> from the sensor represent the ambient light illuminance reading
>>>>> expressed in lux. Use IIO_CHAN_INFO_PROCESSED instead of
>>>>> IIO_CHAN_INFO_RAW to signify that the data are pre-processed.
>>>>>
>>>>> [1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf
>>>>>
>>>>> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
>>>>
>>>> Hm. Whilst it's a fix in a sense, the original didn't really 'break'
>>>> the ABI so I worry a little that this change may break others.
>>>> Irritating as it is, perhaps we should keep the _RAW and add _PROCESSED
>>>> (which will then be exactly the same value).
>>>> We'll also then need a comment in the code, that leaving the _RAW
>>>> elements was for ABI compatibility.
>>>>
>>>> What do others think?
>>>
>>> I'm not an IIO guru, but this does sound sensible. Do you know if any userland
>>> code which actually uses the ACPI ALS already ?
>> It's more than likely as Gnome at least supports using them to control screen
>> brightness. Hopefully that code is able to cope with the correct ABI though as
>> well as the old one. Anyhow, we seem to have a reasonable consensus.
>
> I looked into this and Gnome uses iio-proxy-sensor to handle iio
> devices. As of now it, only looks for in_illuminance_input, so it
> currently doesn't work with acpi-als. I've also found a bug report [1]
> of an acpi-als user stating the same.
>
> [1] https://github.com/hadess/iio-sensor-proxy/issues/46
Good fine. I'll apply this as a fix in that case and mark it for stable.
Jonathan
>
>> Gabriele, are you happy to do a version of the patch with the _RAW version
>> left along side your _PROCESSED version and a comment saying that it is for
>> compatibility only?
>>
>> Jonathan
>>>
>>> Best regards,
>>> Marek Vasut
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-01-16 12:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 15:21 [PATCH] iio: light: acpi-als: Report data as processed rather than raw Gabriele Mazzotta
2016-01-09 16:31 ` Jonathan Cameron
2016-01-09 17:27 ` Marek Vasut
2016-01-11 19:18 ` Jonathan Cameron
2016-01-11 19:20 ` Marek Vasut
2016-01-12 0:15 ` Gabriele Mazzotta
2016-01-12 15:27 ` Gabriele Mazzotta
2016-01-16 12:57 ` Jonathan Cameron [this message]
2016-01-11 10:16 ` Crt Mori
2016-01-11 19:15 ` Jonathan Cameron
2016-01-12 15:21 ` [PATCH v2] iio: light: acpi-als: Report data as processed Gabriele Mazzotta
2016-01-16 13:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569A3E20.9080707@kernel.org \
--to=jic23@kernel.org \
--cc=gabriele.mzt@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=marxin.liska@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).