From: Jonathan Cameron <jic23@kernel.org>
To: Ludovic Desroches <ludovic.desroches@atmel.com>, nicolas.ferre@atmel.com
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup
Date: Sat, 23 Jan 2016 16:17:22 +0000 [thread overview]
Message-ID: <56A3A792.2000901@kernel.org> (raw)
In-Reply-To: <1453106516-17935-2-git-send-email-ludovic.desroches@atmel.com>
On 18/01/16 08:41, Ludovic Desroches wrote:
> Use var type for sizeof argument instead of the struct name.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Applied, thanks.
Jonathan
> ---
> drivers/iio/adc/at91-sama5d2_adc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index f2d8bd5..dbee13a 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -353,8 +353,7 @@ static int at91_adc_probe(struct platform_device *pdev)
> struct resource *res;
> int ret;
>
> - indio_dev = devm_iio_device_alloc(&pdev->dev,
> - sizeof(struct at91_adc_state));
> + indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*st));
> if (!indio_dev)
> return -ENOMEM;
>
>
next prev parent reply other threads:[~2016-01-23 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 8:41 [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type Ludovic Desroches
2016-01-18 8:41 ` [PATCH 2/2] iio:adc:at91-sama5d2: code cleanup Ludovic Desroches
2016-01-23 16:17 ` Jonathan Cameron [this message]
2016-01-23 16:16 ` [PATCH 1/2] iio:adc:at91-sama5d2: fix vref_uv type Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A3A792.2000901@kernel.org \
--to=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).